Conversation
darinkrauss
requested changes
Feb 21, 2020
Contributor
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
Please push the target-specific changes up to the project level.
Contributor
Author
Sure. I only updated the necessary targets, but I can update for the project instead. |
darinkrauss
requested changes
Feb 22, 2020
Contributor
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
Sorry, not to be pedantic, but I meant change the project settings (as you did) and remove the per-target settings (so just the project settings takes effect).
Contributor
|
The project was setup so that all of the common settings were at the project level and only the few per-target specific changes were specified in the target settings. |
Contributor
Author
No my bad. I should have reverted the target specific updates. Doing that now. |
ps2
added a commit
that referenced
this pull request
Apr 21, 2023
…-service Remote PR Set #2: Introduce RemoteCommands
ps2
added a commit
that referenced
this pull request
Apr 21, 2023
ps2
added a commit
that referenced
this pull request
Apr 21, 2023
…-command-service Revert "Remote PR Set #2: Introduce RemoteCommands"
ps2
added a commit
that referenced
this pull request
May 3, 2023
* Embed TidepoolKit * Default to production environment * Use app provided client id * Tidepool backend does not support automated as bolus type * Fix upload of automatic boluses, and invalid pumpSettings. Updates for host identifier and version * Roundtrip localizations * Updates from Lokalise * Show login email on settings page * Updated translations from Lokalise on Thu Feb 9 13:30:18 CST 2023 * Do not upload Loop temp basals as automatic, to clean up Tidepool Web rendering * Move remote command parsing and validation to RemoteDataService * Revert "Remote PR Set #2: Introduce RemoteCommands" * Re-enable tracking of automatic flag for temp basal, and add for scheduled basal * Updated translations from Lokalise on Sat Mar 18 14:01:08 CDT 2023 * Updated translations from Lokalise on Sat Mar 18 15:11:44 CDT 2023 * Updated translations * Remove TidepoolKitUI reference from TidepoolServiceKitUITests * Tests compiling. Basal rate fixes. Not all tests passing yet * hostIdentifier/version updates for tests * Remove TidepoolKitUI references * Ensure food entries have name set * Nil names allow for meals, but not empty strings * Log errors during initialization * Mark automated boluses as such, and show environment in settings if not production * Update README.md * Update README.md * Updating to new TidepoolKit with keycloak based auth (#11) * Updating to new TidepoolKit with keycloak based auth * SettingsView using TidepoolService as ObservedObject * Tweak logo size * Fix issues with state restoration and re-logging in. Add alert when session loss is detected * Improve DataSetId caching * Do not allow environment switching when logged in * Tweak wording * Update tests * Remote PR Set 2: Introduce RemoteCommands * Support client-specific clientIds for auth * Remove unused code * Cleanup from review * Xcode project updates --------- Co-authored-by: Bill Gestrich <3207996+gestrich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.