forked from DylanVann/react-native-fast-image
-
Notifications
You must be signed in to change notification settings - Fork 1
update from upstream #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tianling536
wants to merge
288
commits into
tianling536:master
Choose a base branch
from
DylanVann:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just better formatted.
Show local images on iOS and Android.
## [8.1.9](v8.1.8...v8.1.9) (2020-07-17) ### Bug Fixes * wrong cache type ([#688](#688)) [skip ci] ([94e2256](94e2256))
## [8.1.10](v8.1.9...v8.1.10) (2020-07-17) ### Bug Fixes * update SDWebImage and SDWebImageWebPCoder ([#689](#689)) ([9646456](9646456))
# [8.2.0](v8.1.10...v8.2.0) (2020-07-17) ### Features * export ResizeMode and Priority types ([#678](#678)) ([e33664f](e33664f))
iOS image has its own properties for cache and if fallback is true and regular image is being rendered we can't set FastImage's cache value because it doesn't match.
## [8.2.1](v8.2.0...v8.2.1) (2020-07-17) ### Bug Fixes * remove cache property if using fallback ([ba0f238](ba0f238))
…TypeScript (#666) - in testing [eslint-plugin-react-native-a11y](https://github.com/FormidableLabs/eslint-plugin-react-native-a11y) with `react-native-fast-image`, I noticed that a11y props such as `accessibilityIgnoresInvertColors` are missing from FastImage's TypeScript definitions - in theory the "proper" fix for this would be to make `FastImageProps` extend `ImagePropsBase` from React Native, because ultimately FastImage [spreads Props down](https://github.com/DylanVann/react-native-fast-image/blob/master/src/index.tsx#L150-L160) to React Native's Image component (including a11y props) - attempting this "proper" fix proved problematic in practice due to incompatibilities between the two interfaces - instead rather than extending the entirety of `ImagePropsBase` (which itself extends `AccessibilityProps`) we can resolve this by simply also extending `AccessibilityProps`
## [8.2.2](v8.2.1...v8.2.2) (2020-07-17) ### Bug Fixes * accessibilityIgnoresInvertColors prop not recognised when using TypeScript ([#666](#666)) ([22f89e4](22f89e4)), closes [/github.com/DylanVann/react-native-fast-image/blob/master/src/index.tsx#L150-L160](https://github.com//github.com/DylanVann/react-native-fast-image/blob/master/src/index.tsx/issues/L150-L160)
* Bump the dependency of SDWebImage into 5.8+ because of the SDWebImageDownloaderRequestModifier convenient API usage * Fix the implementation on iOS for per-image-request-header-setup. Should not use `SDWebImageDownloader` which manage the global shared headers. Use the context option of request modifier. * Add the support for data:image URL for WebP images * Alaways bypass invalid SSL certificate error, same behavior like React-Native itself * Fix the implementation of request modifier on SDWebImage, which have bugs on 5.8.0 (will fix in 5.8.1), revert the dependency bump * Revert the changes to bypass SSL error * Remove the unused Podfile.lock changes
# [8.3.0](v8.2.2...v8.3.0) (2020-07-17) ### Features * **ios:** allow for for per-image-request-headers ([#691](#691)) ([4a7cd64](4a7cd64))
## [8.3.1](v8.3.0...v8.3.1) (2020-07-17) ### Bug Fixes * **android:** make center ResizeMode work correctly ([d648ef8](d648ef8))
No need to send events via UI thread. This causes app to use main thread unnecessary that may result in a ARN exception.
## [8.3.2](v8.3.1...v8.3.2) (2020-07-17) ### Bug Fixes * **android:** remove explicit use of UI thread ([#698](#698)) ([5d2894e](5d2894e))
## [8.3.3](v8.3.2...v8.3.3) (2020-11-01) ### Bug Fixes * xcode 12 compatibility ([#732](#732)) ([23c3955](23c3955))
## [8.3.4](v8.3.3...v8.3.4) (2020-11-17)
## [8.3.5](v8.3.4...v8.3.5) (2021-07-06) ### Bug Fixes * add react@17 as peer dependency ([#790](#790)) ([27bd586](27bd586))
## [8.3.6](v8.3.5...v8.3.6) (2021-07-08)
## [8.3.7](v8.3.6...v8.3.7) (2021-07-24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.