[Android] Fixed memory leak #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome! Thanks so much ✨ Currently |
Contributor
Author
|
@DylanVann awesome! I noticed this leak first on On a side note, i have patched 4.0.14 with this fix to production (an app with over 2 million downloads and thousands of new users per day) without problems. |
saghul
added a commit
to jitsi/react-native-fast-image
that referenced
this pull request
Aug 30, 2018
DylanVann#214 but for 4.0.14.
saghul
added a commit
to saghul/jitsi-meet
that referenced
this pull request
Aug 30, 2018
Fixes a memory leak in Android: DylanVann/react-native-fast-image#214 We are using our fork which is 4.0.14 + the leak fix because the last version (5.0.3 at the time of this writing) contains a bug that prevents us for using it: DylanVann/react-native-fast-image#208
lyubomir
pushed a commit
to jitsi/jitsi-meet
that referenced
this pull request
Aug 30, 2018
Fixes a memory leak in Android: DylanVann/react-native-fast-image#214 We are using our fork which is 4.0.14 + the leak fix because the last version (5.0.3 at the time of this writing) contains a bug that prevents us for using it: DylanVann/react-native-fast-image#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with leakcanary and noticed some memory leaks on Android. This PR fixes some of them. Credits go to @chaitanya0bhagvan for fixing those already in PR #98. I mainly did split this fix from the border-radius implementation in the same PR.
At the moment the Android implementation uses static constants which never get releaed. Also got rid of HashMap in favor of WeakHashMap.