storage: replace standard gzip with klauspost/compress to increase ef…

…fiency (pingcap#43129) (pingcap#43186) (pingcap#43203) close pingcap#43128
ti-chi-bot · Apr 19, 2023 · 29116c0 · 29116c0
1 parent c741cfc
commit 29116c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/br/pkg/storage/BUILD.bazel b/br/pkg/storage/BUILD.bazel
@@ -38,8 +38,9 @@ go_library(
         "@com_github_azure_azure_sdk_for_go_sdk_azcore//policy",
         "@com_github_azure_azure_sdk_for_go_sdk_azidentity//:azidentity",
         "@com_github_azure_azure_sdk_for_go_sdk_storage_azblob//:azblob",
-        "@com_github_golang_snappy//:snappy",
         "@com_github_google_uuid//:uuid",
+        "@com_github_klauspost_compress//gzip",
+        "@com_github_klauspost_compress//snappy",
         "@com_github_klauspost_compress//zstd",
         "@com_github_pingcap_errors//:errors",
         "@com_github_pingcap_kvproto//pkg/brpb",

diff --git a/br/pkg/storage/writer.go b/br/pkg/storage/writer.go
@@ -2,11 +2,11 @@ package storage
 
 import (
 	"bytes"
-	"compress/gzip"
 	"context"
 	"io"
 
-	"github.com/golang/snappy"
+	"github.com/klauspost/compress/gzip"
+	"github.com/klauspost/compress/snappy"
 	"github.com/klauspost/compress/zstd"
 	"github.com/pingcap/errors"
 	"github.com/pingcap/log"

diff --git a/table/column.go b/table/column.go
@@ -300,6 +300,10 @@ func CastValue(ctx sessionctx.Context, val types.Datum, col *model.ColumnInfo, r
 	if returnErr && err != nil {
 		return casted, err
 	}
+	if err != nil {
+		logutil.BgLogger().Debug("[debug] ConvertTo FieldType failed", zap.Stringer("FieldType", &col.FieldType),
+			zap.Stringer("Datum", val), zap.Error(err))
+	}
 	if err != nil && types.ErrTruncated.Equal(err) && col.GetType() != mysql.TypeSet && col.GetType() != mysql.TypeEnum {
 		str, err1 := val.ToString()
 		if err1 != nil {