storage: replace standard gzip with klauspost/compress to improve efficiency #43129
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
br/pkg/storage/writer.go
Outdated
| @@ -2,11 +2,11 @@ package storage | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "compress/gzip" | |||
| "context" | |||
| "io" | |||
|
|
|||
| "github.com/golang/snappy" | |||
There was a problem hiding this comment.
How about replacing snappy as well?
There was a problem hiding this comment.
addressed in 607d490
ti-chi-bot
added
status/LGT2
|
/retest |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 607d490
|
ti-chi-bot
added
the
status/can-merge
|
/retest |
|
/rebuild |
|
/retest |
|
/cherry-pick release-6.5-20230314-v6.5.1 |
|
@lichunzhu: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
lichunzhu
changed the title
What problem does this PR solve?
Issue Number: close #43128
Problem Summary:
What is changed and how it works?
replace standard gzip with klauspost/compress to increase effiency
Check List
Tests
After this lightning's speed from 2x no compressed to almost the same with no compressed data.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.