Skip to content

Add skip options for test app creation #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2020
Merged

Add skip options for test app creation #371

merged 5 commits into from
Apr 4, 2020

Conversation

alextrueman
Copy link
Contributor

Related to point 1 of this comment

@alextrueman
Copy link
Contributor Author

Hey there @composerinteralia 😅
Looks like it became a bit faster, but I was required to remove some gems in this PR(we can merge 1st and 3rd points of the issue in this PR, I think, what your thoughts on it?) 😅

composerinteralia
composerinteralia reviewed Apr 4, 2020
View reviewed changes
Copy link
Collaborator

@composerinteralia composerinteralia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Appraisals
@@ -47,15 +47,12 @@ end
appraise "rails6.0" do
gem "byebug"
gem "capybara", ">= 2.15"
gem "jbuilder", "~> 2.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these gems from the other versions as well, if possible. We might speed things up a little for those test runs as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also see if we can get rid of capybara, selenium-webdriver, and web-console, which shouldn't be needed anymore since we are in api mode.

features/step_definitions/rails_steps.rb
options = "--skip-bootsnap --skip-javascript"
options =
%w[
--api
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like --api automatically takes care of --skip-javascript and --skip-sprockets, but I sort of like keeping those options here anyway, to make it more explicit what we are trying to leave out. 👍

@composerinteralia
Copy link
Collaborator

Excellent! I'm loving this much faster test suite. These test used to 6-12 minutes each, now they are 2-3 minutes each.

@composerinteralia composerinteralia merged commit 4c63a12 into thoughtbot:master Apr 4, 2020
@alextrueman
Copy link
Contributor Author

Excellent! I'm loving this much faster test suite. These test used to 6-12 minutes each, now they are 2-3 minutes each.

Yeah, it's awesome, I wasn't thought it become so much faster 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@composerinteralia composerinteralia composerinteralia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextrueman @composerinteralia