Skip to content

Commit 4c63a12

Browse files
authored
Add skip options for test app creation (#371)
Prior to this commit the tests generated a full rails app, but didn't need many of the libraries included by default. Unneeded gems make the test suite slower, and increase the chance of getting errors when new versions of each gem come out.
1 parent 49ed76c commit 4c63a12

File tree

6 files changed

+12
-41
lines changed

6 files changed

+12
-41
lines changed

Appraisals

-20
Original file line numberDiff line numberDiff line change
@@ -2,60 +2,40 @@
22
appraise "rails5.0" do
33
gem "sqlite3", "~> 1.3.6"
44
gem "byebug"
5-
gem "jbuilder", "~> 2.5"
65
gem "listen", "~> 3.0.5"
76
gem "puma", "~> 3.0"
87
gem "rails", "~> 5.0.7", ">= 5.0.7.2"
9-
gem "sass-rails", "~> 5.0"
108
gem "spring"
119
gem "spring-watcher-listen", "~> 2.0.0"
1210
gem "uglifier", ">= 1.3.0"
13-
gem "web-console", ">= 3.3.0", group: :development
1411
end
1512

1613
appraise "rails5.1" do
1714
gem "byebug"
18-
gem "capybara", ">= 2.15"
19-
gem "jbuilder", "~> 2.5"
2015
gem "listen", ">= 3.0.5", "< 3.2"
2116
gem "puma", "~> 3.7"
2217
gem "rails", "~> 5.1.7"
23-
gem "sass-rails", "~> 5.0"
24-
gem "selenium-webdriver"
2518
gem "spring"
2619
gem "spring-watcher-listen", "~> 2.0.0"
2720
gem "sqlite3", "~> 1.3.6"
28-
gem "web-console", ">= 3.3.0", group: :development
2921
end
3022

3123
appraise "rails5.2" do
3224
gem "byebug"
33-
gem "capybara", ">= 2.15"
34-
gem "chromedriver-helper"
35-
gem "jbuilder", "~> 2.5"
3625
gem "listen", ">= 3.0.5", "< 3.2"
3726
gem "puma", "~> 3.11"
3827
gem "rails", "~> 5.2.4", ">= 5.2.4.2"
39-
gem "sass-rails", "~> 5.0"
40-
gem "selenium-webdriver"
4128
gem "spring"
4229
gem "spring-watcher-listen", "~> 2.0.0"
4330
gem "sqlite3", "~> 1.3.6"
44-
gem "web-console", ">= 3.3.0", group: :development
4531
end
4632

4733
appraise "rails6.0" do
4834
gem "byebug"
49-
gem "capybara", ">= 2.15"
50-
gem "jbuilder", "~> 2.7"
5135
gem "listen", ">= 3.0.5", "< 3.2"
5236
gem "puma", "~> 4.1"
5337
gem "rails", "~> 6.0.2", ">= 6.0.2.2"
54-
gem "sass-rails", ">= 6"
55-
gem "selenium-webdriver"
5638
gem "spring"
5739
gem "spring-watcher-listen", "~> 2.0.0"
5840
gem "sqlite3", "~> 1.4"
59-
gem "web-console", ">= 3.3.0", group: :development
60-
gem "webdrivers"
6141
end

features/step_definitions/rails_steps.rb

+12-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
When /^I create a new rails application$/ do
2-
options = "--skip-bootsnap --skip-javascript --skip-bundle"
2+
options =
3+
%w[
4+
--api
5+
--skip-bootsnap
6+
--skip-javascript
7+
--skip-action-mailer
8+
--skip-active-storage
9+
--skip-action-cable
10+
--skip-sprockets
11+
--skip-bundle
12+
].join(" ")
13+
314
template = "-m ../../features/support/rails_template"
415
result = run_command("bundle exec rails new test_app #{options} #{template}")
516

gemfiles/rails5.0.gemfile

-3
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,11 @@ gem "rspec-rails"
1010
gem "rubocop", "0.54", require: false
1111
gem "sqlite3", "~> 1.3.6"
1212
gem "byebug"
13-
gem "jbuilder", "~> 2.5"
1413
gem "listen", "~> 3.0.5"
1514
gem "puma", "~> 3.0"
1615
gem "rails", "~> 5.0.7", ">= 5.0.7.2"
17-
gem "sass-rails", "~> 5.0"
1816
gem "spring"
1917
gem "spring-watcher-listen", "~> 2.0.0"
2018
gem "uglifier", ">= 1.3.0"
21-
gem "web-console", ">= 3.3.0", group: :development
2219

2320
gemspec name: "factory_bot_rails", path: "../"

gemfiles/rails5.1.gemfile

-5
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,11 @@ gem "rake"
99
gem "rspec-rails"
1010
gem "rubocop", "0.54", require: false
1111
gem "byebug"
12-
gem "capybara", ">= 2.15"
13-
gem "jbuilder", "~> 2.5"
1412
gem "listen", ">= 3.0.5", "< 3.2"
1513
gem "puma", "~> 3.7"
1614
gem "rails", "~> 5.1.7"
17-
gem "sass-rails", "~> 5.0"
18-
gem "selenium-webdriver"
1915
gem "spring"
2016
gem "spring-watcher-listen", "~> 2.0.0"
2117
gem "sqlite3", "~> 1.3.6"
22-
gem "web-console", ">= 3.3.0", group: :development
2318

2419
gemspec name: "factory_bot_rails", path: "../"

gemfiles/rails5.2.gemfile

-6
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ gem "rake"
99
gem "rspec-rails"
1010
gem "rubocop", "0.54", require: false
1111
gem "byebug"
12-
gem "capybara", ">= 2.15"
13-
gem "chromedriver-helper"
14-
gem "jbuilder", "~> 2.5"
1512
gem "listen", ">= 3.0.5", "< 3.2"
1613
gem "puma", "~> 3.11"
1714
gem "rails", "~> 5.2.4", ">= 5.2.4.2"
18-
gem "sass-rails", "~> 5.0"
19-
gem "selenium-webdriver"
2015
gem "spring"
2116
gem "spring-watcher-listen", "~> 2.0.0"
2217
gem "sqlite3", "~> 1.3.6"
23-
gem "web-console", ">= 3.3.0", group: :development
2418

2519
gemspec name: "factory_bot_rails", path: "../"

gemfiles/rails6.0.gemfile

-6
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ gem "rake"
99
gem "rspec-rails"
1010
gem "rubocop", "0.54", require: false
1111
gem "byebug"
12-
gem "capybara", ">= 2.15"
13-
gem "jbuilder", "~> 2.7"
1412
gem "listen", ">= 3.0.5", "< 3.2"
1513
gem "puma", "~> 4.1"
1614
gem "rails", "~> 6.0.2", ">= 6.0.2.2"
17-
gem "sass-rails", ">= 6"
18-
gem "selenium-webdriver"
1915
gem "spring"
2016
gem "spring-watcher-listen", "~> 2.0.0"
2117
gem "sqlite3", "~> 1.4"
22-
gem "web-console", ">= 3.3.0", group: :development
23-
gem "webdrivers"
2418

2519
gemspec name: "factory_bot_rails", path: "../"

0 commit comments

Comments
 (0)