Add a few more ZZIdl methods #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 70.68% 70.53% -0.16%
==========================================
Files 350 350
Lines 111868 111877 +9
==========================================
- Hits 79075 78910 -165
- Misses 32793 32967 +174
|
thofma
reviewed
Feb 19, 2024
src/NumField/QQ.jl
Outdated
| is_subset(I::ZZIdl, J::ZZIdl) = is_divisible_by(gen(J), gen(I)) | ||
|
|
||
| radical(I::ZZIdl) = ideal(ZZ, radical(gen(I))) | ||
| primary_decomposition(I::ZZIdl) = [ (ideal(ZZ, p^k), ideal(ZZ, p)) for (p,k) in factor(gen(I)) ] |
There was a problem hiding this comment.
I think this will fail for the zero ideal?
There was a problem hiding this comment.
Indeed, fixed both radical and primary_decomposition for the zero ideal. Also fixed intersect for more or fewer than 2 arguments, and added test cases triggering all that.
fingolfin
force-pushed
the
mh/ZZIdl-extras
branch
from
c058abb
to
c1788bb
Compare
fieker
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.