Skip to content

[Dashboard] Update support email to include wallet address (DASH-75) #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR refactors the prepareEmailBody function to use a single props object for parameters, enhancing readability and maintainability. It also updates the parameters to include name and walletAddress, while modifying how the markdown content is generated.

Detailed summary

  • Changed prepareEmailBody function to accept a single props object.
  • Added new parameters: name and walletAddress.
  • Updated destructuring of props for better clarity.
  • Modified markdown template to include name and walletAddress instead of address.
  • Updated the call to prepareEmailBody to match the new structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Oct 16, 2024

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 9:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 17, 2024 9:33pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 17, 2024 9:33pm
wallet-ui ⬜️ Skipped (Inspect) Oct 17, 2024 9:33pm

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: e67a300

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 06:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 06:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 06:28 Inactive
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2024
Copy link
Contributor Author

kien-ngo commented Oct 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo marked this pull request as ready for review October 16, 2024 06:28
@kien-ngo kien-ngo force-pushed the kien/update-support-form-to-incl-address branch from 8d1c4c8 to 9609d99 Compare October 16, 2024 06:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 06:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 06:29 Inactive
@kien-ngo kien-ngo changed the base branch from kien/improve-test-cov-oct-16 to main October 16, 2024 06:29
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 06:29 Inactive
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (00a6a56) to head (e67a300).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5055   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 00a6a56
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 4.1 s (+25.92% 🔺) 5 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 8.4 s (+27.75% 🔺) 10.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 186 ms (+22.32% 🔺) 283 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 115 ms (-55.74% 🔽) 125 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 611 ms (-44.13% 🔽) 959 ms

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

@kien-ngo kien-ngo force-pushed the kien/update-support-form-to-incl-address branch from 96a17f5 to d5b48da Compare October 17, 2024 21:00
@kien-ngo kien-ngo force-pushed the kien/update-support-form-to-incl-address branch from d5b48da to f1ea349 Compare October 17, 2024 21:04
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 21:04 Inactive
@kien-ngo kien-ngo requested a review from jnsdls October 17, 2024 21:05
Copy link
Member

@jnsdls the unrelated changes are removed by kien now - can you remove change request?

Copy link
Contributor

graphite-app bot commented Oct 17, 2024

Merge activity

…5055)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refactors the `prepareEmailBody` function to accept a single `props` object instead of multiple parameters. It also updates the function to include `name` and `walletAddress`, while modifying the email body to reflect these changes.

### Detailed summary
- Changed `prepareEmailBody` to accept a single `props` object.
- Added `name` and `walletAddress` to the `props` object.
- Updated the email body to include `# Name: ${name}` and `# Wallet address: ${walletAddress}`.
- Modified the call to `prepareEmailBody` to pass a structured object instead of separate arguments.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the kien/update-support-form-to-incl-address branch from f1ea349 to e67a300 Compare October 17, 2024 21:23
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 17, 2024 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 17, 2024 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 17, 2024 21:23 Inactive
@graphite-app graphite-app bot merged commit e67a300 into main Oct 17, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/update-support-form-to-incl-address branch October 17, 2024 21:33
@vercel vercel bot temporarily deployed to Production – wallet-ui October 17, 2024 21:33 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 17, 2024 21:33 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 17, 2024 21:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants