[SDK] Improve general test cases #5054

kien-ngo · 2024-10-16T06:21:07Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR adds a new test case to the resolveName functionality, ensuring that an error is thrown when trying to resolve a name for an address that does not own any Unstoppable Domains (UD).

Detailed summary

Added import for TEST_ACCOUNT_D from ~test/test-wallets.js.
Introduced a new test case to check error handling in resolveName.
The test verifies that an appropriate error message is thrown for addresses without UD ownership.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-16T06:21:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:29am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:29am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:29am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 6:29am

changeset-bot · 2024-10-16T06:21:11Z

⚠️ No Changeset found

Latest commit: 1628fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-16T06:21:13Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-16T06:21:21Z

[SDK] Improve general test cases #5054 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-10-16T06:25:05Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	1.5 s (-30.74% 🔽)	2.3 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	3 s (-19.52% 🔽)	5.1 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	98 ms (-11.63% 🔽)	195 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	46 ms (+112.74% 🔺)	56 ms
thirdweb/react (minimal + tree-shaking)	17.36 KB (0%)	348 ms (0%)	507 ms (+192.67% 🔺)	854 ms

codecov · 2024-10-16T06:27:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (0e26a88) to head (1628fa2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
+ Coverage   45.29%   45.30%   +0.01%     
==========================================
  Files        1059     1059              
  Lines       54754    54754              
  Branches     3959     3958       -1     
==========================================
+ Hits        24803    24809       +6     
+ Misses      29260    29254       -6     
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 0e26a88
packages	`40.25% <ø> (+0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

graphite-app · 2024-10-22T06:17:53Z

Merge activity

Oct 22, 2:17 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 22, 2:29 AM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR introduces new tests for resolving Unstoppable Domains and updates the `mintToBatch` test for `ERC1155` contracts, including the handling of NFT retrieval and ensuring proper error handling. ### Detailed summary - Added a test case in `resolveName.test.ts` to check error handling for addresses without a domain. - Updated the `mintToBatch.test.ts` to use `describe.runIf` for conditional execution. - Refactored the `mintToBatch` test to include NFT retrieval and validation after minting. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added the packages label Oct 16, 2024

kien-ngo marked this pull request as ready for review October 16, 2024 06:21

kien-ngo requested review from joaquim-verges, gregfromstl and jnsdls as code owners October 16, 2024 06:21

vercel bot deployed to Preview – wallet-ui October 16, 2024 06:23 View deployment

vercel bot deployed to Preview – thirdweb_playground October 16, 2024 06:24 View deployment

kien-ngo mentioned this pull request Oct 16, 2024

[Dashboard] Update support email to include wallet address (DASH-75) #5055

Merged

vercel bot deployed to Preview – thirdweb-www October 16, 2024 06:30 View deployment

vercel bot deployed to Preview – docs-v2 October 16, 2024 06:33 View deployment

kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 16, 2024 — with Graphite App

kien-ngo changed the title ~~[SDK] Improve general test cases~~ [SDK] Improve general test cases (dont merge yet I have more to add) Oct 17, 2024

kien-ngo force-pushed the kien/improve-test-cov-oct-16 branch from cc572ca to a1586a5 Compare October 22, 2024 06:07

kien-ngo changed the title ~~[SDK] Improve general test cases (dont merge yet I have more to add)~~ [SDK] Improve general test cases Oct 22, 2024

joaquim-verges approved these changes Oct 22, 2024

View reviewed changes

vercel bot deployed to Preview – wallet-ui October 22, 2024 06:15 View deployment

vercel bot deployed to Preview – thirdweb_playground October 22, 2024 06:16 View deployment

vercel bot deployed to Preview – thirdweb-www October 22, 2024 06:16 View deployment

vercel bot deployed to Preview – docs-v2 October 22, 2024 06:17 View deployment

kien-ngo force-pushed the kien/improve-test-cov-oct-16 branch from a1586a5 to 1628fa2 Compare October 22, 2024 06:18

vercel bot deployed to Preview – wallet-ui October 22, 2024 06:21 View deployment

vercel bot deployed to Preview – thirdweb_playground October 22, 2024 06:21 View deployment

vercel bot deployed to Preview – thirdweb-www October 22, 2024 06:29 View deployment

vercel bot deployed to Preview – docs-v2 October 22, 2024 06:29 View deployment

graphite-app bot merged commit 1628fa2 into main Oct 22, 2024
31 checks passed

graphite-app bot deleted the kien/improve-test-cov-oct-16 branch October 22, 2024 06:29

vercel bot deployed to Production – wallet-ui October 22, 2024 06:31 View deployment

vercel bot deployed to Production – thirdweb_playground October 22, 2024 06:31 View deployment

vercel bot deployed to Production – docs-v2 October 22, 2024 06:32 View deployment

vercel bot deployed to Production – thirdweb-www October 22, 2024 06:39 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Improve general test cases #5054

[SDK] Improve general test cases #5054

Uh oh!

kien-ngo commented Oct 16, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Oct 16, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 16, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 16, 2024

Uh oh!

kien-ngo commented Oct 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 16, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 16, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 22, 2024 •

edited by kien-ngo

Loading

Uh oh!

Uh oh!

Uh oh!

[SDK] Improve general test cases #5054

[SDK] Improve general test cases #5054

Uh oh!

Conversation

kien-ngo commented Oct 16, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 22, 2024 • edited by kien-ngo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

kien-ngo commented Oct 16, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 16, 2024 •

edited

Loading

changeset-bot bot commented Oct 16, 2024 •

edited

Loading

kien-ngo commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading

graphite-app bot commented Oct 22, 2024 •

edited by kien-ngo

Loading