This repository has been archived by the owner on May 3, 2024. It is now read-only.
add MintWithOptions (#116) #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adam-maj
commented
Mar 17, 2023
adam-maj
commented
- so we dont have await which blocks our server
- and provide our own tx opts
* so we dont have await which blocks our server * and provide our own tx opts
adam-maj
commented
Mar 17, 2023
| @@ -53,16 +53,26 @@ func newERC721SignatureMinting(provider *ethclient.Client, address common.Addres | |||
| // // Learn more about how to craft a payload in the Generate() function | |||
| // signedPayload, err := contract.Signature.Generate(payload) | |||
| // tx, err := contract.Signature.Mint(context.Background(), signedPayload) | |||
| func (signature *ERC721SignatureMinting) Mint(ctx context.Context, signedPayload *SignedPayload721) (*types.Transaction, error) { | |||
| message, err := signature.mapPayloadToContractStruct(ctx, signedPayload.Payload) | |||
| func (signature *ERC721SignatureMinting) MintAndAwait(ctx context.Context, signedPayload *SignedPayload721) (*types.Transaction, error) { | |||
There was a problem hiding this comment.
Any particular reason to rename this here? If possible, would probably be best to keep the Mint API here available just so it isn't a breaking change
There was a problem hiding this comment.
as a sdk.. we should be really explicit and obvious when we are doing loop/poll .. hence the suffix
There was a problem hiding this comment.
sent another pr then: #118
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.