Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

add MintWithOptions #118

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Conversation

ricebin
Copy link
Contributor

@ricebin ricebin commented Mar 18, 2023

  • so we dont have await which blocks our server
  • and provide our own tx opts
  • Deprecate existing Mint() and prefer new MintAndAwait

ricebin added 3 commits March 15, 2023 12:44
* so we dont have await which blocks our server
* and provide our own tx opts
@ricebin
Copy link
Contributor Author

ricebin commented Mar 22, 2023

ping?

@adam-maj adam-maj changed the base branch from main to am/mint March 24, 2023 02:14
@adam-maj adam-maj merged commit 9d959e6 into thirdweb-dev:am/mint Mar 24, 2023
adam-maj added a commit that referenced this pull request Mar 24, 2023
* add MintWithOptions (#116)

* so we dont have await which blocks our server
* and provide our own tx opts

* add MintWithOptions (#118)

* add MintWithOptions
* so we dont have await which blocks our server
* and provide our own tx opts

* fix build

* deprecate

---------

Co-authored-by: Adam Majmudar <64697628+adam-maj@users.noreply.github.com>

* Fix line

---------

Co-authored-by: ricebin <ricebin@users.noreply.github.com>
Co-authored-by: Adam Majmudar <adam@Adams-MacBook-Pro.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants