-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace with new tn-models-fp #204
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
483d038
replace with new tn-models-fp
paribaker 70fc1e6
updated to remove comments
paribaker ea88024
updated axios
paribaker 8622f56
fix missing deps
paribaker 93c7a1e
remvoed users
paribaker d363f64
checking implicit exports
paribaker 90f1703
updated user api
paribaker 16845aa
import axios instance
paribaker 9c73166
updated user resgistration
paribaker ca47ae0
updated fn
paribaker 1d8c8eb
make base shape readonly
paribaker 1223953
updated baseModelShape
paribaker d521408
updated typo
paribaker 666a654
updated to include token as opt
paribaker 401d469
fix readonly import
paribaker c443347
change to confirm password
paribaker 5afc5eb
updated reset flow
paribaker 5f50bd5
Merge branch 'main' into feature/vue-to-models-fp
paribaker 30a5c6d
small fixes
paribaker d7234d3
updated code with new libs
paribaker 33f44c6
merge main
paribaker c42d41c
remove lock file
paribaker 3bb0c6c
updated package.json
paribaker d7b64fe
Merge branch 'main' into feature/vue-to-models-fp
paribaker 9f4cc27
Merge branch 'main' into feature/vue-to-models-fp
paribaker 1274573
remove read only
paribaker 0084f37
upadted readonly
paribaker 935effc
changed to tailwind 3.2.2 for async error
paribaker bc631b2
trying tailwind 3.2.2
paribaker aa3dd24
pin tailwind version
paribaker 26a7eee
resolve comments
paribaker 778a22b
updated with merge conflicts
paribaker 6bf9082
added api to axios and removed from libs
paribaker 676c68a
fix for sign up, temp use react for test
paribaker 4d5d804
trigger react
paribaker bb7adb5
fix skip lock issue
paribaker 9320df5
updated to force react
paribaker 64d9ca5
updated to remove react force
paribaker 65d7348
form fix for react sign up
paribaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting....looks like they deprecated this flag.
pypa/pipenv#5805
Sounds like this should be replaced with
pipenv run pip install
Not sure if it has the --dev and --deploy flag for regular pip though.
The reason why this was here was to test the app with the latest versions of a library (instead of the pinned versions in the lock file). This would encourage devs to version bump more often because you know it works with the latest.
And if some new thing breaks the build, we can investigate it sooner instead of waiting to hit that error when we are trying to version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeaaa....pip install couldn't possibly have the --dev flag. Lets merge this as-is and open a github issue to figure out a way to bring this back using pipenv