-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace with new tn-models-fp #204
Conversation
{{cookiecutter.project_slug}}/clients/web/vue3/src/services/AxiosClient.js
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/web/vue3/src/services/base-model.js
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/web/vue3/src/services/users/api.js
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/services/user/api.ts
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/web/react/src/services/user/api.ts
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/web/vue3/src/services/users/api.js
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/web/vue3/src/services/users/api.js
Show resolved
Hide resolved
@oudeismetis @lakardion okay this is giving me a headache. To resolve once and for all I've added the Will test this out on mobile and then check the react side! |
@@ -45,7 +45,7 @@ jobs: | |||
- name: Pytest, McCabe, and Coverage | |||
run: | | |||
cd my_project | |||
pipenv install --dev --deploy --skip-lock | |||
pipenv install --dev --deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting....looks like they deprecated this flag.
pypa/pipenv#5805
Sounds like this should be replaced with pipenv run pip install
Not sure if it has the --dev and --deploy flag for regular pip though.
The reason why this was here was to test the app with the latest versions of a library (instead of the pinned versions in the lock file). This would encourage devs to version bump more often because you know it works with the latest.
And if some new thing breaks the build, we can investigate it sooner instead of waiting to hit that error when we are trying to version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeaaa....pip install couldn't possibly have the --dev flag. Lets merge this as-is and open a github issue to figure out a way to bring this back using pipenv
I appreciate the efforts to keep things standard, though technically it doesn't matter if Vue and React differ a bit in their approach. |
What this does
Moves vue js to the new tn-models-fp library
How to test
Sign up to app
login to app
Start forgot password flow (note emails are not set up)