cpu: multiprocessing: add new broadcast rutine #9217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdobrowolski
requested review from
tmleman,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
from
1623d3c
to
6f32aba
Compare
pjdobrowolski
requested review from
lyakh,
iuliana-prodan and
abonislawski
as code owners
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
3 times, most recently
from
4dd512f
to
712a54c
Compare
tmleman
requested changes
Jun 11, 2024
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
from
712a54c
to
4f14da1
Compare
tmleman
requested changes
Jun 11, 2024
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
from
4f14da1
to
9338e68
Compare
tmleman
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
For me, it's already OK. The only thing I would change if I had time is the description. It shows that it's the result of a squash. My proposal is:
west.yml: update Zephyr to 2efc447c1b4
This commit updates the SOF codebase to align with recent changes in the Zephyr project. It includes the following changes:
- Updates the Zephyr project to the revision `2efc447c1b41efd23447ea180731d673114f06d8`.
- Introduces a new routine `arch_sched_broadcast_ipi()` to replace the deprecated `arch_sched_ipi()` for broadcasting IPIs.
- Replaces the deprecated `z_arch_esf_t` struct with the new `struct arch_esf` in the `k_sys_fatal_error_handler` function.
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
from
9338e68
to
321ea19
Compare
|
@tmleman thanks for help! |
This commit updates the SOF codebase to align with recent changes in the Zephyr project. It includes the following changes: - Updates the Zephyr to the rev 2efc447c1b41efd23447ea180731d673114f06d8 - Introduces a new routine `arch_sched_broadcast_ipi()` to replace the deprecated `arch_sched_ipi()` for broadcasting IPIs. - Replaces the deprecated `z_arch_esf_t` struct with the new `struct arch_esf` in the `k_sys_fatal_error_handler` function. Signed-off-by: Dobrowolski, PawelX <pawelx.dobrowolski@intel.com>
pjdobrowolski
force-pushed
the
broadcast_rutine
branch
from
321ea19
to
32ade85
Compare
gbernatxintel
approved these changes
Jun 11, 2024
lgirdwood
approved these changes
Jun 11, 2024
|
@pjdobrowolski good stuff, CI mostly green. One build failure for TGL though (I suspect we need a copy and paste change from MTL to TGL) |
marcinszkudlinski
approved these changes
Jun 11, 2024
|
This duplicates a part of #9199. I was OoO for the last two days, so couldn't update it to account for the now merged zephyrproject-rtos/zephyr#73856 . I'll update #9199 in a couple of minutes |
|
ok, I've merged #9199 since it had the build fix for TGL too. Thanks all, think we are back to health again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms that support IPIs allow them to be broadcast via the
new arch_sched_broadcast_ipi() routine (replacing arch_sched_ipi()).
Those that also allow IPIs to be directed to specific CPUs may
use arch_sched_directed_ipi() to do so.