-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: multiprocessing: add new broadcast rutine #9217
Conversation
1623d3c
to
6f32aba
Compare
4dd512f
to
712a54c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend combining the three commits into a single commit to ensure that each commit in the repository is buildable and maintains git bisect functionality.
712a54c
to
4f14da1
Compare
4f14da1
to
9338e68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it's already OK. The only thing I would change if I had time is the description. It shows that it's the result of a squash. My proposal is:
west.yml: update Zephyr to 2efc447c1b4
This commit updates the SOF codebase to align with recent changes in the Zephyr project. It includes the following changes:
- Updates the Zephyr project to the revision `2efc447c1b41efd23447ea180731d673114f06d8`.
- Introduces a new routine `arch_sched_broadcast_ipi()` to replace the deprecated `arch_sched_ipi()` for broadcasting IPIs.
- Replaces the deprecated `z_arch_esf_t` struct with the new `struct arch_esf` in the `k_sys_fatal_error_handler` function.
9338e68
to
321ea19
Compare
@tmleman thanks for help! |
This commit updates the SOF codebase to align with recent changes in the Zephyr project. It includes the following changes: - Updates the Zephyr to the rev 2efc447c1b41efd23447ea180731d673114f06d8 - Introduces a new routine `arch_sched_broadcast_ipi()` to replace the deprecated `arch_sched_ipi()` for broadcasting IPIs. - Replaces the deprecated `z_arch_esf_t` struct with the new `struct arch_esf` in the `k_sys_fatal_error_handler` function. Signed-off-by: Dobrowolski, PawelX <pawelx.dobrowolski@intel.com>
321ea19
to
32ade85
Compare
@pjdobrowolski good stuff, CI mostly green. One build failure for TGL though (I suspect we need a copy and paste change from MTL to TGL) |
This duplicates a part of #9199. I was OoO for the last two days, so couldn't update it to account for the now merged zephyrproject-rtos/zephyr#73856 . I'll update #9199 in a couple of minutes |
ok, I've merged #9199 since it had the build fix for TGL too. Thanks all, think we are back to health again. |
Platforms that support IPIs allow them to be broadcast via the
new arch_sched_broadcast_ipi() routine (replacing arch_sched_ipi()).
Those that also allow IPIs to be directed to specific CPUs may
use arch_sched_directed_ipi() to do so.