Skip to content

ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ktrzcinx wants to merge 1 commit into from
Closed

ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params #2273

ktrzcinx wants to merge 1 commit into from

Conversation

@ktrzcinx
Copy link
Member

@ktrzcinx ktrzcinx commented Jul 14, 2020 •
edited
Loading

This field is both kernel and firmware sorce code, so it
should be deprecated and allow to delete unused definitions.

Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com

Related with thesofproject/sof#3179

@plbossart
Copy link
Member

plbossart commented Jul 14, 2020

ABI Change, let's follow the process, shall we?

@ktrzcinx ktrzcinx changed the title ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params [RFC] ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params Jul 14, 2020
@ktrzcinx ktrzcinx added the ABI involves ABI changes, need extra attention label Jul 14, 2020
lyakh
lyakh previously approved these changes Jul 15, 2020
View reviewed changes
@ktrzcinx ktrzcinx changed the title [RFC] ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params Jul 29, 2020
@ktrzcinx
Copy link
Member Author

ktrzcinx commented Jul 29, 2020

SOFCI TEST

kv2019i
kv2019i reviewed Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktrzcinx The FW PR is closed, ok to close this as well?

Another I didn't find from FW discussion, was this ever used? Can not setting this field, break some older FW? I'm guessing that not, but just want to confirm.

@ktrzcinx
ASoC: buffer: Remove buffer_fmt from sof_ipc_stream_params
7ad1ff8 
This field is both kernel and firmware source code, so it
should be deprecated and allow to delete unused definitions.

Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
@ktrzcinx
Copy link
Member Author

ktrzcinx commented Aug 19, 2020

was this ever used?

In FW source code in version from

commit c0dfb4e62ab6ef7ae4712450cf5b9e5abd9159af (HEAD, tag: v0.9)
Author: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Date:   Wed Sep 21 15:57:22 2016 +0100

    core: initial import of open source DSP firmware

This value also is unused, so I guess nothing has change between.

@ktrzcinx The FW PR is closed, ok to close this as well?

Yes

@ktrzcinx ktrzcinx closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019i kv2019i kv2019i left review comments

@lyakh lyakh lyakh left review comments

@bardliao bardliao Awaiting requested review from bardliao bardliao is a code owner

@juimonen juimonen Awaiting requested review from juimonen

@keyonjie keyonjie Awaiting requested review from keyonjie

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@singalsu singalsu Awaiting requested review from singalsu

Assignees

No one assigned

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ktrzcinx @plbossart @lyakh @kv2019i