Add lspci app, restructure PCI legacy interrupts (INTx) initialization
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinaboos
requested changes
Dec 13, 2023
kevinaboos
changed the title
lspci commandlspci app, restructure PCI legacy interrupts (INTx) initialization
kevinaboos
approved these changes
Dec 22, 2023
Comment on lines
+245
to
+246
| let intx_numbers = INTX_NUMBERS.lock(); | ||
| intx_numbers[$num].expect("uninitialized x86 PCI INTx handler") |
There was a problem hiding this comment.
This is a bit funky and kinda hard to read; I think this is a good place to just include this logic in the actual body of the interrupt handler and issue an EOI directly in the body instead of returning HandlerDidNotSendEoi.
Another thing we could do is to include the interrupt number alongside the waker instance or alongside the INTX_DEVICES static, in order to "ensure" those are always available.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
) * INTX interrupt handler registration for PCI devices is now done lazily on both architectures. * On aarch64, the interrupt numbers are known statically. * On x86_64, we expect that the driver or module using the PCI device knows which interrupt number to use. Technically this information can be discovered through ACPI AML, but we do not yet support that because it is tedious and difficult. * Clarify PCI interrupt information functions, e.g., MSI/MSI-x support, etc. Co-authored-by: Kevin Boos <1139460+kevinaboos@users.noreply.github.com> ac5712c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR depends on #1071)
This adds an
lspcicommand:It takes no argument and always lists all devices.