-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EHCI USB Controllers Support #1059
Open
NathanRoyer
wants to merge
64
commits into
theseus-os:theseus_main
Choose a base branch
from
NathanRoyer:usb-ehci
base: theseus_main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once you merge in the changes from #1081, feel free to mark this as "ready for review" and then request a review from me. |
Ok this is ready for a first review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings early support for EHCI USB controllers. It currently supports directly connected High Speed devices (no hub / low-speed device / full speed device support), and allows:
NB 1: USB Requests work on top of control transfers.
High Level Todos:
NB 2: isochronous transfers are low-priority because they're a legacy concept and they were mainly use for audio, which we don't support in theseus.
Low Level Todos:
Option<Interface>
so that they can be removed from the controllers while they in turn modify the controllers themselves. It's pretty ugly.