Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove namespace maximum match #195

Closed
wants to merge 1 commit into from
Closed

remove namespace maximum match #195

wants to merge 1 commit into from

Conversation

plachta11b
Copy link

Fix #194

@thesayyn
Copy link
Owner

CI is running. you'll probably need to check in generated files.

@plachta11b plachta11b changed the title remove maximum namespace match remove namespace maximum match Mar 16, 2023
@plachta11b
Copy link
Author

Are those files uploaded somewhere in form of a test artifact or do I need to run the test locally?

@thesayyn
Copy link
Owner

Are those files uploaded somewhere in form of a test artifact or do I need to run the test locally?

you just need to run bazel test //... it will tell you what you need to do in the error message

@martyphee martyphee mentioned this pull request Mar 23, 2023
Closed
@martyphee
Copy link

martyphee commented Mar 23, 2023 •
edited
Loading

You should be able to just run bazel run //test/no_namespace:diff_2 to update the test file. It's passing locally for me after doing that.

It would be great to get this merged.

@martyphee martyphee mentioned this pull request Mar 23, 2023
Merged
@thesayyn
Copy link
Owner

closing in favor of #199

@thesayyn thesayyn closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imported package name / namespace only partially removed
3 participants
@plachta11b @thesayyn @martyphee