no_namespace is causing invalid typescript to be generated

[martyphee]

With namespaces I get code which looks like this

get vehicle() {
    return pb_1.Message.getWrapperField(this, dependency_1.zego.protobuf.vehicles.v2.Vehicle, 1);
}

But when it's off --ts_opt=no_namespace

get vehicle() {
    return pb_1.Message.getWrapperField(this, dependency_1.vehiclesv2Vehicle, 1);
}

The issue is this part
dependency_1.vehiclesv2Vehicle

Which should be

dependency_1.Vehicle

Generate step

find ${PROTO_PATH} -iname '*.proto' -exec protoc \
        --ts_opt=no_namespace \
        --plugin=protoc-gen-ts=${NODE_MODULES_PATH}/.bin/protoc-gen-ts \
        --ts_out="${GEN_SRC_DIR}/zego_protobuf/src" \
        --ts_opt=unary_rpc_promise=true \
        --proto_path=${PROTO_PATH} \
        {} +

Am I missing something?

[martyphee]

Seems to be this line

function removeNamespace(name) {
    if (config.no_namespace) {
        return removeRootParentName(name, packages.find(p => name.startsWith(p))).replace(/\./g, '');
    }
    return name;
}

[martyphee]

Little digging. That function should sort the packages by name first. The issue was it was finding the root package zego but not the full package name which was zego.grpc.vehicles.v2.

Example

[martyphee]

Seems to be a duplicate