-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript changes #114
Typescript changes #114
Conversation
can you squash them so that they are easy to cherry-pick? |
Pretty sure this should do the trick? |
Yea. thanks a lot. just fixed a lot bazel related stuff. still trying to get windows pass. pain. |
looking at the error it almost seems like it is looking for the submodule? |
02003d5
to
339add8
Compare
just permission errors. I give up. I don’t have a windows machine. ngg after its stupid permission errors. |
ebd8686
to
bc08070
Compare
@chris-kruining the branch is ready. could you rebase and resolve conflicts? one last time I promise. i don't need anything that is outside |
My client wouldn't allow me to rebase on /src alone, so you might wanna cherry pick again, So I hope I did this right |
it's worse now tbh. there are conflicts remaining in the files. |
dammit, I'll just reset the branch and manually re-add the files |
wait?! why did it close? because I reset all the changes? |
probably. no worries. just send another one against typescript branch. |
ok, should be fine now. |
Perfect! |
what an adventure with git today 🤣 |
as per #111 (comment)