Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to typescript #111

Merged
merged 4 commits into from
Jan 24, 2022
Merged

refactor: migrate to typescript #111

merged 4 commits into from
Jan 24, 2022

Conversation

thesayyn
Copy link
Owner

@thesayyn thesayyn commented Jan 20, 2022

closes #94 #110. thanks @koblas @chris-kruining

@thesayyn
Copy link
Owner Author

hey fellas. this PR introduces the typescript pipeline. I have figured out most of the things. though I will need your help converting the javascript sources to typescript ones.

  • need to get tests working.
  • need to interop with examples to assert that we don't break anything
  • need to create an automatic release pipeline in our CI

@chris-kruining
Copy link

chris-kruining commented Jan 21, 2022

image

Can I get access so I can push to this PR?

This was referenced Jan 21, 2022
@thesayyn
Copy link
Owner Author

I would like to but only collaborators can get write access. :( but I can cherry-pick your changes if you could open a PR that bases this one.

basically;

git checkout typescript
# make your changes 
git commit -m "tb cherry picked"
git push myorigin typescript

@chris-kruining
Copy link

see #114

@thesayyn thesayyn force-pushed the typescript branch 6 times, most recently from c67316d to ebd8686 Compare January 21, 2022 16:05
@chris-kruining
Copy link

how did the build break?? is the index.js not being compiled?

@thesayyn
Copy link
Owner Author

how did the build break?? is the index.js not being compiled?

i got it. everything is working now.

@chris-kruining
Copy link

I spotted I missed the tsconfig.json file but that didn't do much in it's config

@thesayyn
Copy link
Owner Author

last commit should do the trick.

@thesayyn thesayyn force-pushed the typescript branch 2 times, most recently from 33d8e93 to 0884a5c Compare January 21, 2022 23:42
@thesayyn
Copy link
Owner Author

thesayyn commented Jan 22, 2022

this is almost ready. except one pesky windows line break issue. I hate windows so much. just pain.

@koblas
Copy link
Contributor

koblas commented Jan 22, 2022

You can do it, we're all cheering from the stands!

@chris-kruining
Copy link

this is almost ready. except one pesky windows line break issue. I hate windows so much. just pain.

gotta love proprietary bs 🙄

@thesayyn thesayyn force-pushed the typescript branch 2 times, most recently from 88245eb to 5fb99a4 Compare January 24, 2022 10:06
@thesayyn
Copy link
Owner Author

done. f_u windows.

@thesayyn thesayyn force-pushed the typescript branch 3 times, most recently from d0e03e3 to 653c250 Compare January 24, 2022 10:40
@thesayyn thesayyn merged commit e9bd40e into main Jan 24, 2022
@thesayyn thesayyn deleted the typescript branch January 24, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants