-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to typescript #111
Conversation
hey fellas. this PR introduces the typescript pipeline. I have figured out most of the things. though I will need your help converting the javascript sources to typescript ones.
|
I would like to but only collaborators can get write access. :( but I can cherry-pick your changes if you could open a PR that bases this one. basically; git checkout typescript
# make your changes
git commit -m "tb cherry picked"
git push myorigin typescript |
see #114 |
c67316d
to
ebd8686
Compare
how did the build break?? is the index.js not being compiled? |
i got it. everything is working now. |
I spotted I missed the |
last commit should do the trick. |
33d8e93
to
0884a5c
Compare
this is almost ready. except one pesky windows line break issue. I hate windows so much. just pain. |
You can do it, we're all cheering from the stands! |
gotta love proprietary bs 🙄 |
88245eb
to
5fb99a4
Compare
done. f_u windows. |
d0e03e3
to
653c250
Compare
closes #94 #110. thanks @koblas @chris-kruining