Added Header Image Support

[pincombe]

added Header Image support to PayPal Express Gateway. Supply a link to an image upto 750px x 90px to display using checkout process

[cfreear]

Looks like your commit is failing on Travis because you have used tabs instead of spaces for indentation. Omnipay conforms to PSR-2 so if you change each of your tabs to four (4) spaces it should pass.

[pincombe]

I was going to say I didn't know how to push my changes but it seems to have done it automatically. Sorry i'm a terrible at contributing. Hopefully i'll get better with more experience.

[cfreear]

Haha no worries, Omnipay is the first project I've contributed to so it's been a learning curve for me too!

Looks like Travis is failing now because you have moved your get/set encapsulation methods from PayPal\Message\AbstractRequest to PayPal\ExpressGateway but you are using $this->getHeaderImage() in ExpressAuthorizeRequest where $this refers to the request object not the gateway object.

Moving it back to AbstractRequest is your best bet as ExpressAuthorizeRequest extends this class.

[pincombe]

Ok i've moved the functions into ExpressAuthorizeRequest they will only be used during that stage of the payment process. Sorry If messing things up. I'm happy to keep changing things until your happy with the changes.

[cfreear]

Oops, I'm so sorry, I've just noticed @adrianmacneil asked you to move it to the gateway in your previous pull request #54 so reverting to your previous commit is probably best but in doing that, instead of setting headerImage in your request you will need to set it when you create your gateway in your code that uses Omnipay. Something like:

$gateway = GatewayFactory::create('PayPal_Express');
$gateway->setUsername('test');
//set other gateway parameters like password, landingPage etc.
$gateway->setHeaderImage('http://www.mysite.com/assets/images/headerimage.jpg');

//set $transaction and $card etc.

$response = $gateway->authorize($transaction);

instead of setting it as part of the $transaction array.

Sorry again for messing you around, let me know if any of that isn't clear.

[pincombe]

No its cool man you understand things better than I do. I'll sort that change out and resubmit. :)

[pincombe]

Thx for sorting it. Sorry i did such a poor job. Hopefully i'll do better next time :)

[amacneil]

No worries!