header image support for paypal express

[pincombe]

Hi not sure if my approach is correct but would it be ok to add header image support for paypal express? It is used instead of the business name at the top of the page and can really help customers feel secure and understand the current stage in the payment process. A great implementation of it is on Etsy.com

[amacneil]

Thanks, this looks good. Before I can commit, can you

• fix whitespace so the travis build passes
• add comments to describe what format the headerImage should be (e.g. does it need to be an HTTPS URL?)
• squash everything into a single commit (then force push to github and it will update the pull request)

[amacneil]

Also can you add this to the gateway settings, some people might like to set it globally. Thanks!

[pincombe]

Ok sure :)

Thanks for the feedback. I'm not very experienced with open
source contribution but i'll sort these issues out and send another request
shortly.

On 29 April 2013 13:26, Adrian Macneil notifications@github.com wrote:

Also can you add this to the gateway settings, some people might like to
set it globally. Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/54#issuecomment-17163688
.

[amacneil]

No problem. You can just push to your github branch and it will update the pull request :)

[pincombe]

Hi. I messed up my forked repo so started a new one. I think these changes
are much better than the last ones I made anyway :)

On 29 April 2013 13:35, Adrian Macneil notifications@github.com wrote:

No problem. You can just push to your github branch and it will update the
pull request :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/54#issuecomment-17164040
.