Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump laminas-diactoros, psr/http-message versions #1339

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Apr 18, 2023

Updates the requirements on laminas/laminas-diactoros to allow the latest version.

3.0.0
Release Notes for 3.0.0
Added
This version adds support for PSR-7 v2.0. While we had previously added return type hints in Diactoros, there were a few cases where PSR-7 updated the interfaces to use void returns where we had not. As a result, this release represents a BC break for anybody extending our classes, as defining an extension that uses one of these methods with a mixed return type (or omitting the return type entirely) will result in a type error.

The interfaces affected were Psr\Http\Message\StreamInterface and Psr\Http\Message\UploadedFileInterface.

For consumers, this version should be entirely backwards compatible in usage. For those extending our classes, you will only run into issues when extending implementations of the above interfaces.

@erikn69 erikn69 changed the title Bump psr/http-message version Bump laminas-diactoros, psr/http-message versions May 5, 2023
@thephpleague thephpleague deleted a comment from parallels999 May 5, 2023
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@Sephster
Copy link
Member

Thanks for the PR @erikn69 - just some minor comments from me

@Sephster Sephster merged commit 52638c5 into thephpleague:master Jun 6, 2023
@driesvints
Copy link
Contributor

@Sephster can we maybe release this as a patch release? We're getting so much issues on Passport about this 😅

@Sephster
Copy link
Member

Damn I thought I had sorry @driesvints . Will release tonight

@driesvints
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants