-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow recording custom locations #163
base: master
Are you sure you want to change the base?
Conversation
can we make the path adjustable? i dont use |
@gtxaspec I think I should just outright remove the location restrictions and maybe just show a warning that the user should be careful that theyre saving to a mounted location? Perhaps check |
i would remove location restrictions completely, |
Summary: Add a new value option to the gpio script for retrieving the bare value of a gpio. Use that feature, rather than the /sys/class/gpio tree, to read values in the irled script. Subsequent testing revealed that the gpio directory for the IR LED pin is not available upon boot. The gpio script provides the logic to export the gpio directory. Using the gpio script abstraction allows for reading the gpio without further concern for initialization state. Testing: With the patch, after a reboot, testing irled read: ``` test # irled read 0 test # irled on test # irled read 1 test # ``` After another reboot, testing gpio value option: ``` test # ls /sys/class/gpio/ export gpio57 gpio58 gpio8 gpiochip0 gpiochip32 gpiochip64 unexport test # gpio value 9 0 test # ``` Without the patch, after a reboot, showing prior problem: ``` test # irled read cat: can't open '/sys/class/gpio/gpio9/value': No such file or directory test # irled on test # irled read 1 test # ```
Done. All restrictions removed |
@jayfan0 can you rebase this on the latest master pls? thx |
Currently the local recording complains and denies recordings if an SD card is not inserted.
This PR also checks for valid NFS mounts and allows recording to
/mnt/nfs/*
locations.