Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recording custom locations #163

Open
wants to merge 104 commits into
base: master
Choose a base branch
from

Conversation

jayfan0
Copy link
Contributor

@jayfan0 jayfan0 commented Aug 14, 2024

Currently the local recording complains and denies recordings if an SD card is not inserted.

This PR also checks for valid NFS mounts and allows recording to /mnt/nfs/* locations.

@jayfan0 jayfan0 marked this pull request as ready for review August 14, 2024 14:26
@gtxaspec
Copy link
Collaborator

gtxaspec commented Aug 16, 2024

can we make the path adjustable? i dont use /mnt/nfs for example.
edit:
ideally local recording would allow to record to any specified path, not particularly an sd card or nfs, even smb, or usb drive ,etc

@jayfan0
Copy link
Contributor Author

jayfan0 commented Aug 16, 2024

@gtxaspec I think I should just outright remove the location restrictions and maybe just show a warning that the user should be careful that theyre saving to a mounted location?

Perhaps check if location is in overlayfs then show warning, else no warning
But either way the use can ignore any warnings?

@jayfan0 jayfan0 marked this pull request as draft August 16, 2024 22:13
@gtxaspec
Copy link
Collaborator

i would remove location restrictions completely,
I would display a warning, on any location except anything inside /mnt

themactep and others added 25 commits August 19, 2024 10:11
Summary:
Add a new value option to the gpio script for retrieving
the bare value of a gpio. Use that feature, rather than the
/sys/class/gpio tree, to read values in the irled script.

Subsequent testing revealed that the gpio directory for the
IR LED pin is not available upon boot. The gpio script
provides the logic to export the gpio directory. Using the
gpio script abstraction allows for reading the gpio
without further concern for initialization state.

Testing:

With the patch, after a reboot, testing irled read:
```
test # irled read
0
test # irled on
test # irled read
1
test #
```

After another reboot, testing gpio value option:
```
test # ls /sys/class/gpio/
export      gpio57      gpio58      gpio8       gpiochip0   gpiochip32  gpiochip64  unexport
test # gpio value 9
0
test #
```

Without the patch, after a reboot, showing prior problem:
```
test # irled read
cat: can't open '/sys/class/gpio/gpio9/value': No such file or directory
test # irled on
test # irled read
1
test #
```
@jayfan0 jayfan0 marked this pull request as ready for review August 19, 2024 09:34
@jayfan0
Copy link
Contributor Author

jayfan0 commented Aug 19, 2024

Done. All restrictions removed
Will check if SD card is mounted IF location is set to /mnt/mmcblk0pX
Will display a CAUTION if record path is set outside of /mnt*

@jayfan0 jayfan0 changed the title Allow recording to NFS shares Allow recording custom locations Aug 19, 2024
@gtxaspec
Copy link
Collaborator

gtxaspec commented Sep 7, 2024

@jayfan0 can you rebase this on the latest master pls? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants