irled: Use gpio script to read led value #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themactep
reviewed
Aug 16, 2024
| @@ -33,7 +33,7 @@ case "$mode" in | |||
| gpio clear $pin > /dev/null | |||
| ;; | |||
| read) | |||
| cat /sys/class/gpio/gpio${pin}/value | |||
There was a problem hiding this comment.
the pin you are queryig may be not exported. say a led pin which are defined in the environment but not exported by default. so you will be doing cat from a non-extent file, resulting in an error.
There was a problem hiding this comment.
Yep, new lesson learned. I think this patch should cure the problem, but let me know if you foresee other gotchas.
There was a problem hiding this comment.
Now it will work. Merging. Thank you.
There was a problem hiding this comment.
Thank you! This project is fantastic!
Summary: Add a new value option to the gpio script for retrieving the bare value of a gpio. Use that feature, rather than the /sys/class/gpio tree, to read values in the irled script. Subsequent testing revealed that the gpio directory for the IR LED pin is not available upon boot. The gpio script provides the logic to export the gpio directory. Using the gpio script abstraction allows for reading the gpio without further concern for initialization state. Testing: With the patch, after a reboot, testing irled read: ``` test # irled read 0 test # irled on test # irled read 1 test # ``` After another reboot, testing gpio value option: ``` test # ls /sys/class/gpio/ export gpio57 gpio58 gpio8 gpiochip0 gpiochip32 gpiochip64 unexport test # gpio value 9 0 test # ``` Without the patch, after a reboot, showing prior problem: ``` test # irled read cat: can't open '/sys/class/gpio/gpio9/value': No such file or directory test # irled on test # irled read 1 test # ```
DavidPletcher
force-pushed
the
gpio_irled
branch
from
51def59
to
52a7aa6
Compare
jayfan0
pushed a commit
to jayfan0/thingino-firmware
that referenced
this pull request
Aug 19, 2024
Summary: Add a new value option to the gpio script for retrieving the bare value of a gpio. Use that feature, rather than the /sys/class/gpio tree, to read values in the irled script. Subsequent testing revealed that the gpio directory for the IR LED pin is not available upon boot. The gpio script provides the logic to export the gpio directory. Using the gpio script abstraction allows for reading the gpio without further concern for initialization state. Testing: With the patch, after a reboot, testing irled read: ``` test # irled read 0 test # irled on test # irled read 1 test # ``` After another reboot, testing gpio value option: ``` test # ls /sys/class/gpio/ export gpio57 gpio58 gpio8 gpiochip0 gpiochip32 gpiochip64 unexport test # gpio value 9 0 test # ``` Without the patch, after a reboot, showing prior problem: ``` test # irled read cat: can't open '/sys/class/gpio/gpio9/value': No such file or directory test # irled on test # irled read 1 test # ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new value option to the gpio script for retrieving the bare value of a gpio. Use that feature, rather than the /sys/class/gpio tree, to read values in the irled script.
Subsequent testing revealed that the gpio directory for the IR LED pin is not available upon boot. The gpio script provides the logic to export the gpio directory. Using the gpio script abstraction allows for reading the gpio without further concern for initialization state.
Testing:
With the patch, after a reboot, testing irled read:
After another reboot, testing gpio value option:
Without the patch, after a reboot, showing prior problem: