Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make concat function call compatible with updated scanpy #53

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

lzhus
Copy link
Contributor

@lzhus lzhus commented Dec 2, 2020

In the six cell, run the souce code "adata.var['gene_id'] = adata.var['gene_id-1']" will report a error, perhaps due to the previous variable "adata_tmp" has no the same gene id, and causes the KeyError.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@LuckyMD
Copy link
Contributor

LuckyMD commented Dec 3, 2020

Hi @lzhus,

Thanks! This has been mentioned in several issues, but I never got around to fixing the notebook. I notice that you have a typo though.

if 'gene_id_1' in adata.var.columns: should say 'gene_id-1'.

Copy link
Contributor

LuckyMD commented Dec 7, 2020

Thanks!

@LuckyMD LuckyMD changed the title fix bug Make concat function call compatible with updated scanpy Dec 7, 2020
@LuckyMD LuckyMD self-requested a review December 7, 2020 12:33
@LuckyMD LuckyMD merged commit 7ace03a into theislab:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants