Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for compute_entropy and compute_variance #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeonStadelmann
Copy link

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,387 @@
{
Copy link
Collaborator

@MUCDK MUCDK Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great. now just add a little bit of explanation to the technical side, e.g. what does forward and batch_size mean


Reply via ReviewNB

@@ -0,0 +1,387 @@
{
Copy link
Collaborator

@MUCDK MUCDK Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cond_variance_pca = res_en = ... , i.e. double assignment?


Reply via ReviewNB

@@ -0,0 +1,387 @@
{
Copy link
Collaborator

@MUCDK MUCDK Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to explicitly set the title


Reply via ReviewNB

@@ -0,0 +1,387 @@
{
Copy link
Collaborator

@MUCDK MUCDK Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when having mulitple plots can you please do this with matplotlib subplot with different axes


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having issues with adding colorbars to matplotlib subplots, so I replicated the subplot format using two individual paired scatter plots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants