-
Notifications
You must be signed in to change notification settings - Fork 7
Add predict kwargs in validation step #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If tests are necessary, should they be added in test_cellflow or in test_trainer? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 81.35% 81.82% +0.47%
==========================================
Files 38 38
Lines 2564 2548 -16
Branches 329 321 -8
==========================================
- Hits 2086 2085 -1
+ Misses 334 328 -6
+ Partials 144 135 -9
🚀 New features to boost your workflow:
|
Let's please add a test checking for passing the number of steps of the solver, and make sure if it's 2 steps it's considerablyu faster (e.g. 1 sec) than passing 1e7 steps. Let's add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just add tests!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@LeonStadelmann thanks a lot, looks great! |
No description provided.