Skip to content

Add predict kwargs in validation step #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LeonStadelmann
Copy link
Collaborator

No description provided.

@LeonStadelmann LeonStadelmann requested a review from MUCDK May 1, 2025 17:00
@LeonStadelmann
Copy link
Collaborator Author

If tests are necessary, should they be added in test_cellflow or in test_trainer?

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (4970ad4) to head (c281d9a).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   81.35%   81.82%   +0.47%     
==========================================
  Files          38       38              
  Lines        2564     2548      -16     
  Branches      329      321       -8     
==========================================
- Hits         2086     2085       -1     
+ Misses        334      328       -6     
+ Partials      144      135       -9     
Files with missing lines Coverage Δ
src/cellflow/model/_cellflow.py 73.95% <100.00%> (+1.93%) ⬆️
src/cellflow/training/_trainer.py 98.30% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MUCDK
Copy link
Collaborator

MUCDK commented May 5, 2025

If tests are necessary, should they be added in test_cellflow or in test_trainer?

Let's please add a test checking for passing the number of steps of the solver, and make sure if it's 2 steps it's considerablyu faster (e.g. 1 sec) than passing 1e7 steps.

Let's add it to test_trainer

Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just add tests!

Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@MUCDK
Copy link
Collaborator

MUCDK commented May 23, 2025

@LeonStadelmann thanks a lot, looks great!
Please resolve conflicts with main, then we can merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants