Fixes #37284 - Do not overwrite results #134
Merged
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
missing-vol2
branch
from
7a78019 to
950b6a5
Compare
adamruzicka
changed the title
adamruzicka
force-pushed
the
missing-vol2
branch
from
950b6a5 to
7e585b1
Compare
ofedoren
approved these changes
Jul 25, 2024
Comment on lines
+6
to
+8
| unless %i[error success skipped].include?(action.run_step&.state) | ||
| action.output[:result] = action.output_result | ||
| end |
There was a problem hiding this comment.
If I read it right, we only add result entry for stopped/paused states since otherwise it's already present?
There was a problem hiding this comment.
Yes, it should already be there from https://github.com/theforeman/smart_proxy_dynflow/pull/134/files#diff-f3c605b1717c7b0b34ac0715dcb3867c32689fad5a09c7f73a9de47708fa326bR66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.