Fixes #37284 - Do not overwrite results

lib/smart_proxy_dynflow/action/middleware/assemble_results.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Proxy::Dynflow::Action::Middleware
+  class AssembleResults < ::Dynflow::Middleware
+    def present
+      unless %i[error success skipped].include?(action.run_step&.state)
+        action.output[:result] = action.output_result
+      end
+      pass
+    end
+  end
+end

lib/smart_proxy_dynflow/action/runner.rb

@@ -2,12 +2,16 @@
 
 require 'smart_proxy_dynflow/action/shareable'
 require 'smart_proxy_dynflow/action/external_polling'
+require 'smart_proxy_dynflow/action/middleware/assemble_results'
+
 module Proxy::Dynflow
   module Action
     class Runner < Shareable
       include ::Dynflow::Action::Cancellable
       include ::Proxy::Dynflow::Action::WithExternalPolling
 
+      middleware.use ::Proxy::Dynflow::Action::Middleware::AssembleResults
+
       def run(event = nil)
         case event
         when nil

lib/smart_proxy_dynflow/helpers.rb

@@ -72,16 +72,10 @@ def refresh_output(execution_plan, action)
         end
       end
 
-      def expand_output(action)
-        hash = action.to_hash
-        hash[:output][:result] = action.output_result if action.is_a?(Proxy::Dynflow::Action::Runner)
-        hash
-      end
-
       def execution_plan_status(plan)
         actions = plan.actions.map do |action|
           refresh_output(plan, action)
-          expand_output(action)
+          action.to_hash
         end
         plan.to_hash.merge(:actions => actions)
       end