Refs #33760 - Add host_reports plugin #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ofedoren
force-pushed
the
add-host-reports
branch
from
8d43321 to
3637252
Compare
ofedoren
changed the title
ekohl
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Code wise it looks ok. theforeman/foreman-packaging#7173 hasn't been merged yet (and I don't see a PR for Debian) so I'm hesitant to merge this right now.
|
The packaging PR was merged: theforeman/foreman-packaging#7194 Debian PR: theforeman/foreman-packaging#7169 (I am going to update it for 0.0.5 now too). |
ekohl
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.