Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added smart_proxy_reports new package #7169

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

lzap
Copy link
Member

@lzap lzap commented Oct 15, 2021

For plugin updates, please indicate which repos this should be built into:

  • Nightly

RPM version: #7168

@lzap lzap force-pushed the deb/develop-sphr002 branch from c227227 to 4c1986f Compare October 15, 2021 07:02
@lzap lzap changed the title Added smart_proxy_host_reports 0.0.2 new package Added smart_proxy_host_reports new package Oct 15, 2021
@lzap
Copy link
Member Author

lzap commented Oct 15, 2021

WARNING: I created this as a search and replace of the webhooks plugin. What I don't understand is where the heck the version "0.0.3" is defined. I don't see it anywhere.

@zjhuntin
Copy link
Contributor

@evgeni mind clarifying? ^

@evgeni
Copy link
Member

evgeni commented Oct 15, 2021

In the changelog?

@lzap
Copy link
Member Author

lzap commented Oct 22, 2021

I also bumped the gem to 0.0.4, however, I do not understand where in this patch should I define which is the version I want to build. :-) So I am assuming this is magic...

@lzap
Copy link
Member Author

lzap commented Nov 2, 2021

Do not merge, I am going to rebase this to 0.0.5.

@ekohl ekohl marked this pull request as draft November 2, 2021 14:35
@ekohl
Copy link
Member

ekohl commented Nov 2, 2021

Converted it to a draft so that's clear.

@lzap lzap marked this pull request as ready for review November 10, 2021 07:16
@lzap lzap force-pushed the deb/develop-sphr002 branch from 8292fea to 4db74f7 Compare November 10, 2021 07:16
@lzap
Copy link
Member Author

lzap commented Nov 10, 2021

Renamed "host_reports" to "reports", bumped version to 0.0.5. This is now ready for re-review, thanks guys.

@lzap lzap force-pushed the deb/develop-sphr002 branch from 4db74f7 to 513a5c8 Compare December 14, 2021 07:12
@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Rebased to see what is wrong.

@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Could not find 'json' (>= 2.3.0) - did find: [json-2.1.0]

Hmmm I guess 2.1 is fine.

@lzap lzap force-pushed the deb/develop-sphr002 branch 3 times, most recently from e7ddf2e to 30a2e1e Compare December 14, 2021 09:39
@evgeni evgeni changed the title Added smart_proxy_host_reports new package Added smart_proxy_reports new package Dec 14, 2021
@evgeni
Copy link
Member

evgeni commented Dec 14, 2021

 Could not find 'rack' (>= 2.1.0) - did find: [rack-2.0.6] (Gem::MissingSpecVersionError)

@ekohl
Copy link
Member

ekohl commented Dec 14, 2021

Why does it even depend on rack? I'd expect the Smart Proxy itself to take care of that.

@evgeni
Copy link
Member

evgeni commented Dec 14, 2021

same q for json actually, you don't need to depend on it (heck, you don't even require json anywhere)

@lzap lzap force-pushed the deb/develop-sphr002 branch from 30a2e1e to 2b9f6dd Compare December 14, 2021 11:34
@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Hmmm I see that json is now part of Ruby. That can be removed I guess.

Rake is used in tests, so dev only dependency. But I have it defined in the Gemfile, so what is preferred - to have it in the Gemfile or in the gemspec?

@lzap lzap force-pushed the deb/develop-sphr002 branch from 2b9f6dd to 2e6d874 Compare December 14, 2021 11:41
@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Removed the deps from gemspec, pushed out 0.0.7 - my lucky number!!! Notice that I created this PR for 0.0.2...

You will hardly find a worst packager than me.

@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Huston, we are green. T minus five.

@evgeni
Copy link
Member

evgeni commented Dec 14, 2021

tiny nit, and could you please adjust the commit message to match the new name of the gem? :)

@ekohl
Copy link
Member

ekohl commented Dec 14, 2021

Rake is used in tests, so dev only dependency. But I have it defined in the Gemfile, so what is preferred - to have it in the Gemfile or in the gemspec?

From a packaging perspective I don't think there's a difference since both are ignored.

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
@lzap lzap force-pushed the deb/develop-sphr002 branch from 2e6d874 to bfe5e4d Compare December 14, 2021 13:31
@lzap
Copy link
Member Author

lzap commented Dec 14, 2021

Cool, rebased.

@evgeni evgeni merged commit 9b826db into theforeman:deb/develop Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants