-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added smart_proxy_reports new package #7169
Conversation
c227227
to
4c1986f
Compare
WARNING: I created this as a search and replace of the webhooks plugin. What I don't understand is where the heck the version "0.0.3" is defined. I don't see it anywhere. |
@evgeni mind clarifying? ^ |
In the changelog? |
4c1986f
to
8292fea
Compare
I also bumped the gem to 0.0.4, however, I do not understand where in this patch should I define which is the version I want to build. :-) So I am assuming this is magic... |
Do not merge, I am going to rebase this to 0.0.5. |
Converted it to a draft so that's clear. |
8292fea
to
4db74f7
Compare
Renamed "host_reports" to "reports", bumped version to 0.0.5. This is now ready for re-review, thanks guys. |
4db74f7
to
513a5c8
Compare
Rebased to see what is wrong. |
Could not find 'json' (>= 2.3.0) - did find: [json-2.1.0] Hmmm I guess 2.1 is fine. |
e7ddf2e
to
30a2e1e
Compare
|
Why does it even depend on rack? I'd expect the Smart Proxy itself to take care of that. |
same q for json actually, you don't need to depend on it (heck, you don't even require json anywhere) |
30a2e1e
to
2b9f6dd
Compare
Hmmm I see that json is now part of Ruby. That can be removed I guess. Rake is used in tests, so dev only dependency. But I have it defined in the |
2b9f6dd
to
2e6d874
Compare
Removed the deps from gemspec, pushed out 0.0.7 - my lucky number!!! Notice that I created this PR for 0.0.2... You will hardly find a worst packager than me. |
Huston, we are green. T minus five. |
tiny nit, and could you please adjust the commit message to match the new name of the gem? :) |
From a packaging perspective I don't think there's a difference since both are ignored. |
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
2e6d874
to
bfe5e4d
Compare
Cool, rebased. |
For plugin updates, please indicate which repos this should be built into:
RPM version: #7168