Skip to content

Pin mocha, update minitest #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamlazik1 merged 1 commit into from
Feb 11, 2026
Merged

Pin mocha, update minitest #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ gem 'gettext', '>= 3.1.3', '< 4.0.0'
gem 'hammer_cli_foreman', github: 'theforeman/hammer-cli-foreman', branch: 'master'

group :test do
gem 'minitest'
gem 'minitest', '~> 5.18'
gem 'minitest-spec-context'
gem 'mocha'
gem 'mocha', "~> 2.1.0"
Copy link
Member

@ekohl ekohl Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason it needs to be 2.1.x or can it be < 3?

Copy link
Member Author

@ofedoren ofedoren Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more about being consistent with hammer-cli-foreman, which has the same pin since theforeman/hammer-cli-foreman#618

And since it was 3 years ago I have no idea why I've pinned it like that. It might be that I didn't have much time then to dig through mocha and fix breaking changes for every update.

gem 'rake', '~> 13.0'
gem 'simplecov'
gem 'theforeman-rubocop', '~> 0.1.0'
Expand Down
2 changes: 1 addition & 1 deletion test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


require 'minitest/autorun'
require 'minitest/spec'
require 'minitest/unit'
require "minitest-spec-context"
require "mocha/minitest"

Expand Down