Pin mocha, update minitest#62
Merged
adamlazik1 merged 1 commit intotheforeman:masterfrom Feb 11, 2026
Merged
Conversation
nadjaheitmann
approved these changes
Feb 10, 2026
ekohl
reviewed
Feb 10, 2026
| gem 'minitest', '~> 5.18' | ||
| gem 'minitest-spec-context' | ||
| gem 'mocha' | ||
| gem 'mocha', "~> 2.1.0" |
Member
There was a problem hiding this comment.
Any reason it needs to be 2.1.x or can it be < 3?
Member
Author
There was a problem hiding this comment.
It's more about being consistent with hammer-cli-foreman, which has the same pin since theforeman/hammer-cli-foreman#618
And since it was 3 years ago I have no idea why I've pinned it like that. It might be that I didn't have much time then to dig through mocha and fix breaking changes for every update.
adamruzicka
approved these changes
Feb 10, 2026
Contributor
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
This is in line with what was done in other plugins
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.