Repository navigation
Fixes #39609 - Add missing ouiaId to MenuToggle components - #1055
Merged
Merged
Conversation
Strict checking of ouia ids on PF5 components was introduced with #39562.
There was a problem hiding this comment.
Pull request overview
This PR addresses strict OUIA ID validation for PatternFly v5 by adding missing ouiaId props to MenuToggle components used in the Job Invocation detail UI.
Changes:
- Add
ouiaIdto the status filterMenuToggleused by theSelectin the hosts toolbar. - Add
ouiaIdto the actions kebabMenuToggleused by the bulk-actionsDropdown.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
webpack/JobInvocationDetail/DropdownFilter.js |
Adds an explicit ouiaId to the MenuToggle used as the status filter select toggle. |
webpack/JobInvocationDetail/CheckboxesActions.js |
Adds an explicit ouiaId to the MenuToggle used as the actions kebab dropdown toggle. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict checking of ouia ids on PF5 components was introduced with #39562 / theforeman/foreman#11117.