Repository navigation
Fixes #39562 - Update eslint-plugin-rules require-ouiaid with PF5 components - #11117
Merged
Merged
Conversation
5 tasks
lfu
force-pushed
the
39562_require_ouiaid_pf5
branch
2 times, most recently
from
July 28, 2026 17:49
de0d891 to
c431876
Compare
Contributor
Author
|
Test failure not related to the ouiaId eslint rule change. |
lfu
force-pushed
the
39562_require_ouiaid_pf5
branch
from
July 28, 2026 19:58
c431876 to
810b467
Compare
MariaAga
reviewed
Jul 29, 2026
MariaAga
reviewed
Jul 29, 2026
MariaAga
requested changes
Jul 29, 2026
MariaAga
left a comment
Member
There was a problem hiding this comment.
webpack/assets/javascripts/react_app/components/common/ClipboardCopy/index.js Also imports ClipboardCopy from pf5 so it should have a ouiaid
lfu
force-pushed
the
39562_require_ouiaid_pf5
branch
from
July 29, 2026 14:28
4379983 to
85b05d4
Compare
Contributor
Author
|
@MariaAga Anything else to update? |
Member
|
@lfu I dont see my comment addressed in the PR
|
lfu
force-pushed
the
39562_require_ouiaid_pf5
branch
from
August 3, 2026 16:02
85b05d4 to
aef3c10
Compare
Contributor
Author
|
@MariaAga Updated. |
MariaAga
approved these changes
Aug 11, 2026
MariaAga
left a comment
Member
There was a problem hiding this comment.
code LGTM, had a quick look (with packit) at hosts, host and new token page to make sure nothing weird is happening, and all works well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require-ouiaideslint rule for PatternFly 5 compatibilityMenuToggle(PF5 replacement forDropdownToggle) andClipboardCopy(existing PF component, previously missing from the list)additionaloption parameter to extend the defaults list without overriding themTest plan
ouiaIdon newly added components (e.g.MenuToggle):List of OUIA-compliant PatternFly components: