Repository navigation
Rpm/vendor v4.14.0 - #5687
Merged
Merged
Rpm/vendor v4.14.0#5687
Conversation
evgeni
reviewed
Aug 18, 2020
Comment on lines
+169
to
+171
| %if 0%{?scl:1} | ||
| BuildRequires: %{?scl_prefix_nodejs}npm | ||
| %if 0%{!?scl:1} | ||
| %else |
Member
There was a problem hiding this comment.
that's the part that's breaking it on el8, please revert.
sharvit
force-pushed
the
rpm/vendor-v4.14.0
branch
from
August 18, 2020 09:19
fa170ef to
19154b9
Compare
Author
|
Thanks @evgeni, updated. I am using npm2rpm v6.0.0 downloaded from npm. |
Member
|
There is no release with theforeman/npm2rpm@bfcbb9d yet. @ekohl could you do a release of npm2rpm please? |
evgeni
approved these changes
Aug 25, 2020
Member
Forgot to update here, but https://github.com/theforeman/npm2rpm/releases/tag/6.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating vendor to the latest version, required for: theforeman/foreman#7896