Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend detection of falsy functions (2) #32

Merged
merged 3 commits into from
Sep 14, 2018

Conversation

moufmouf
Copy link
Member

This PR extends #31 with:

  • additional unit tests
  • special implementation for apcu_fetch and apc_fetch
  • regenerated functions

kasperg and others added 2 commits September 14, 2018 12:03
The documentation for getcwd states:
“Returns the current working directory on success, or FALSE on failure.”

Support detection for “on failure” in addition to “on error”.
@coveralls
Copy link

coveralls commented Sep 14, 2018

Pull Request Test Coverage Report for Build 70

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 26.503%

Files with Coverage Reduction New Missed Lines %
src/DocPage.php 4 90.0%
src/Scanner.php 21 0.0%
Totals Coverage Status
Change from base Build 61: 0.2%
Covered Lines: 119
Relevant Lines: 449

💛 - Coveralls

@moufmouf moufmouf force-pushed the getcwd branch 3 times, most recently from 1725b26 to 522b8b0 Compare September 14, 2018 12:15
@moufmouf
Copy link
Member Author

Done! 70 new functions detected.
Thank you @kasperg !

@moufmouf moufmouf merged commit 0fe27e0 into thecodingmachine:master Sep 14, 2018
@moufmouf moufmouf deleted the getcwd branch September 14, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants