Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand detection of falsy functions #31

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

kasperg
Copy link
Contributor

@kasperg kasperg commented Sep 14, 2018

The documentation for getcwd states:
“Returns the current working directory on success, or FALSE on failure.”

Support detection for "on failure" in addition to "on error".

This will fix #29.

@moufmouf
Copy link
Member

Thanks! Actually, I've done the test locally too and very interestingly, the PR adds ~70 new functions that were previously undetected!!! \o/

The documentation for getcwd states:
“Returns the current working directory on success, or FALSE on failure.”

Support detection for “on failure” in addition to “on error”.
@kasperg kasperg changed the title Expand detection of falsy functions to add getcwd Expand detection of falsy functions Sep 14, 2018
@moufmouf moufmouf merged commit fa9d680 into thecodingmachine:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing getcwd function?
2 participants