Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for composer 2 #42

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add support for composer 2 #42

merged 1 commit into from
Nov 4, 2020

Conversation

acrollet
Copy link
Contributor

@acrollet acrollet commented Nov 3, 2020 •
edited
Loading

This fixes #41

I've tested installing and removing with and without local nodejs with composer 1 & 2.

@acrollet acrollet changed the title Fixes #41: Add support for composer 2 Add support for composer 2 Nov 3, 2020
@acrollet acrollet mentioned this pull request Nov 3, 2020
Closed
@moufmouf
Copy link
Member

moufmouf commented Nov 4, 2020

Thanks a lot @acrollet !
I've tested this too and it works great.
Merging this now! 👍

@moufmouf moufmouf merged commit 8b26f68 into thecodingmachine:1.0 Nov 4, 2020
@acrollet
Copy link
Contributor Author

acrollet commented Nov 4, 2020

@moufmouf you're welcome! The work was sponsored by https://github.com/department-of-veterans-affairs :-)

@ElijahLynn
Copy link

Thanks @acrollet! And thank you for your work on this too @moufmouf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to work with Composer 2, needs upgrade to composer-plugin-api 2.0.0
3 participants
@acrollet @moufmouf @ElijahLynn