Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to work with Composer 2, needs upgrade to composer-plugin-api 2.0.0 #41

Closed
ElijahLynn opened this issue Oct 30, 2020 · 2 comments · Fixed by #42
Closed

Update to work with Composer 2, needs upgrade to composer-plugin-api 2.0.0 #41

ElijahLynn opened this issue Oct 30, 2020 · 2 comments · Fixed by #42

Comments

@ElijahLynn
Copy link

See https://github.com/thecodingmachine/nodejs-installer/blob/1.0/composer.json#L17.
@ElijahLynn ElijahLynn mentioned this issue Oct 30, 2020
Closed
13 tasks
@moufmouf
Copy link
Member

Indeed! I won't have time this week to work on the upgrade. However, if anyone is interested in opening a PR, I'll gladly accept it!

@ElijahLynn
Copy link
Author

Indeed! I won't have time this week to work on the upgrade. However, if anyone is interested in opening a PR, I'll gladly accept it!

Thanks, our team will have time to work on it in the coming weeks if there isn't a PR for it yet. I think it might be as simple as doing a composer update composer-plugin-api as I have seen some other libraries just change that and test it and it works.

@HillLiu HillLiu mentioned this issue Oct 31, 2020
Closed
This was referenced Nov 2, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for composer 2 acrollet/nodejs-installer
2 participants
@moufmouf @ElijahLynn