Fix v21 permissions #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an apk and a small script for performing install and permission grant in one go * Minor changes * Update README file with instructions for installing the app * Minor changes pt 2 * Simplify permission grant and update README
* Add the uninstall and cleanup script * Update README to reflect the uninstall changes, in a new Caveat section
* Add more validation rules * Expose lastUsedProxy from AppSettings in the viewModel * Add shape for Toggle button, Info icon and colour definitions * Add accessibility, dimens, strings and styles resources * Apply basic styling to the manager fragment * Add error handing in the proxy manager fragment * Add content description for the different states of the toggle button * Show the information dialog when pressing the info icon * Use orEmpty instead of Elvis operator
* Implement a ThemeSwitcher to alternate between dark and light mode * Remove unnecessary Suppress * Use Activity context for the ThemeSwitcher (addressing PR comments)
* Fix keyboard behaviour * Add custom font * Add colour palette as well as colour selectors * Add toggle power icon * Add dimens and styles values * Add the power image in the toggle layer list * Add global theme settings * Apply final UI tweaks in the fragment * Add launcher icon * Remove unnecessary files and tidy up * Add placeholder Night mode
* Add an intent filter to the main activity to capture long-pressing the tile * Add a proper tile icon * Fix broken test
* Fix launching new intent from tile * Add widget resources, dimens, etc * Add widget layout * Apply layout from Widget service * Small code tidy up * Update Unit Tests
* Add dynamic version code and name * Add some screenshots * Added images to the README file * Change image on README
… into fix/v21_permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Why?
On Android 5.x we still have signature permissions and, apparently, it requires an extra permission to be granted:
WRITE_SETTINGS.What?