Implement Widget UI #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontesino
commented
Jul 9, 2020
| @@ -1,20 +1,110 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Widgets have a limited set of Views that you can use, definitely not a ConstraintLayout :(
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
============================================
- Coverage 39.22% 36.69% -2.54%
Complexity 54 54
============================================
Files 17 17
Lines 232 248 +16
Branches 26 27 +1
============================================
Hits 91 91
- Misses 140 156 +16
Partials 1 1
|
geftimov
approved these changes
Jul 9, 2020
| android:minHeight="@dimen/widget_min_height" | ||
| android:minResizeWidth="@dimen/widget_min_resizable_width" | ||
| android:minResizeHeight="@dimen/widget_min_resizable_height" | ||
| android:previewImage="@drawable/widget_preview" | ||
| android:resizeMode="horizontal|vertical" | ||
| android:updatePeriodMillis="86400000" |
There was a problem hiding this comment.
Is this update period how often the widget is going to sync with the new saved proxy?
If this is once a day and you change the proxy in the meantime from the app,
will the widget show the right proxy?
There was a problem hiding this comment.
Yep, it's a required value when creating the widget to automatically refresh, set as once a day to save battery.
The proxy is updated in real time via a broadcast sent every time you update the proxy from other sources (app, tile, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We had a placeholder widget while waiting for the designs
What?
Implemented the widget UI, making it a bit resizable.
Added widget preview on the widget selector
Bonus
Fixed a small bug on the tile while launching a new intent.
Some screenshots:
