Added Dockerfile for user image #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog box has been removed from the "close" operation. Changed the way the processes are killed too.
Changed the way the processes are killed in windows.
Fixed backend spawn
PureScript recently got an update and it introduced breaking changes in the code. As we are already working on the port to pure Haskell, it is better to just explicitly use the old versions
Enforces Utilization of clientStackYaml as per other areas of the Build.hs file in order to maintain a consistent way to reference these files.
clientStackYaml was hardcoded
…-Of-clientStackYaml-Global-Var (57) Build.hs file should utilize global stack values where possible
The links were relative to the repo and were not working as supposed.
Fix website links in README file
use the `stack` installation in env instead of an absolute path - solves theam#60
This pull-request adds a file explorer to the "Open Project" dialog which allows the users to navigate through their filesystem just like a file manager, instead of being required to enter the absolute path. The explorer's path is synced with the input's path, so they both work at the same time.
…o fns (59) refactor: move fsTree to it's own module
(59) fix: avoid racing conditions in ToolbarAction action update
rendering of the HTML to be done
(82) fix: re-activate script tags after rendering the HTML (solves theam#82)
(77) Rename SimpleMDE into CodeMirror
Remove redundant constraint breaking build due to -Werror
(86) Add a button to hide the editor
|
BTW, addresses #71 |
ocramz
commented
Jun 11, 2017
| @@ -24,6 +24,9 @@ setValueForId _ _ = return () | |||
| setHtmlForId :: String -> String -> IO () | |||
| setHtmlForId _ _ = return () | |||
|
|
|||
| activateScriptTags :: String -> IO () | |||
| activateScriptTags _ = return () | |||
|
|
|||
| show :: String -> IO () | |||
| show _ = return () | |||
There was a problem hiding this comment.
why all these return () things? Is it a placeholder for something else?
There was a problem hiding this comment.
Because as we have our application right now, transient requires to have the same code on the client and the server. If the code is GHCJS-specific, it needs to be replaced with these empty return s
|
@ocramz somehow this changes lots of files. Why is it so? 🤔 |
|
Oh yeah, you made it to develop, sorry. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just creates a Docker image with the haskell.do binary for users.
theam/haskell.do:0.9.3.haskell-do 8080upon startup, so a user would be able to interact with it by sayingAs a further improvement, Docker may also be used internally by
stackto build the haskell.do binary against various operating systems (versions, environments etc)