Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the stack installation in env instead of an absolute path - solves #60 #62

Merged
merged 1 commit into from
Jun 7, 2017
Merged

use the stack installation in env instead of an absolute path - solves #60 #62

merged 1 commit into from
Jun 7, 2017

Conversation

mdibaiee
Copy link
Contributor

@mdibaiee mdibaiee commented Jun 7, 2017 •
edited
Loading

solves #60

@mdibaiee mdibaiee mentioned this pull request Jun 7, 2017
Closed
@NickSeagull
Copy link
Contributor

Looks cool, does Windows have a where command? It would be cool to make a step in the right direction. :)

@mdibaiee
Copy link
Contributor Author

mdibaiee commented Jun 7, 2017

@NickSeagull well, now that I think of it, why don't we just use the stack in the environment? I mean we don't have to specify the full path, do we? stack new ... should do, hmm? 😁

@NickSeagull
Copy link
Contributor

True, stack itself will do

@mdibaiee mdibaiee changed the title read stack's path using which stack - solves #60 use the stack installation in env instead of an absolute path - solves #60 Jun 7, 2017
@mdibaiee
Copy link
Contributor Author

mdibaiee commented Jun 7, 2017

@NickSeagull turned out to be much simpler, rebased

@NickSeagull
Copy link
Contributor

Awesome, will merge it ASAP, gonna generate a new build with these changes soon.

@itrion itrion requested a review from NickSeagull June 7, 2017 16:30
NickSeagull
NickSeagull approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@NickSeagull NickSeagull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NickSeagull NickSeagull merged commit 6bd4a56 into theam:master Jun 7, 2017
@mdibaiee mdibaiee deleted the stack-path branch June 8, 2017 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSeagull NickSeagull NickSeagull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdibaiee @NickSeagull