Kapulimbs #65523

Kapu1178 · 2022-03-17T02:53:35Z

About The Pull Request

Ports Kapulimbs 1.0 & 1.1 from Shiptest, while trimming some unrelated code.

Kapulimbs is a bodypart & update icons rewrite I created with a few specific intentions:

Simplify the code
Allow players to create frankensteins of different species parts
Enable non-humanoid species to be created

How is this achieved?

Bodyparts are now pathed to their specific species, and they can have their own unique life loops, appearances, and anything else a bodypart child should have. A "bodytypes" bitfield is utilized to differentiate important attributes, such as BODYTYPE_ORGANIC and BODYTYPE_HUMANOID.

Why It's Good For The Game

Better code AND better fun.

Changelog

🆑
add: Limbgrower limbs are now a sickly green
refactor: Digitigrade legs should now behave consistently.
refactor: Limbs will no longer update appearance as owner is transferred, allowing for multi-species frankensteins
fix: CHANGELING TRANSFORM FUNCTIONS PROPERLY
del: Synths and synth-related mechanics (Synth fugative)
/:cl:

code/modules/surgery/bodyparts/helpers.dm

code/modules/mob/living/carbon/human/species.dm

code/modules/mob/living/carbon/carbon_update_icons.dm

code/modules/antagonists/changeling/changeling.dm

code/__HELPERS/icons.dm

code/__DEFINES/mobs.dm

code/modules/mob/living/carbon/human/human_update_icons.dm

code/modules/surgery/bodyparts/species_parts/vox_bodyparts.dm

optimumtact · 2022-03-17T05:55:09Z

furry shit

code/__DEFINES/mobs.dm

Archanial · 2022-03-17T09:43:43Z

furry shit

Don't pretend you don't like it

SuperNovaa41 · 2022-03-17T10:57:52Z

Most of your changelog isnt relevant to players

ExcessiveUseOfCobblestone · 2022-03-17T15:05:51Z

Transformation erp enabler

AlinaStarkova · 2022-03-17T16:10:45Z

how would it work with changelings if people swap species limbs? does the dna sting/absorbtion remember the limbs the target had? and what happens when the target changes limbs again? is that a case of "out of date DNA" that a re-sting will solve or does the DNA update?

Kapu1178 · 2022-03-17T17:46:31Z

Most of your changelog isnt relevant to players

Changelogs are for coders too. Thats why refactor and code are tags.

ShibaInuLord · 2022-03-17T18:00:06Z

i sure do love getting a message specifying i have human limbs every time i get hit

JohnFulpWillard · 2022-03-17T19:05:56Z

Most of your changelog isnt relevant to players

Changelogs are for coders too. Thats why refactor and code are tags.

code/modules/zombie/organs.dm

.github/CODEOWNERS

tralezab · 2022-04-02T01:08:09Z

yeet

Kapu1178 · 2022-04-02T01:37:23Z

https://tenor.com/view/goku-super-saiyan-super-saiyan2-super-saiyan2goku-goku-vegeta-gif-23177097

Sinestia · 2022-04-02T02:09:51Z

o shit grats

timothymtorres · 2022-04-02T10:18:04Z

code/modules/games/wizoff.dm

-	return msg
+	. = ..()
+	. += span_notice("Remember the rules of Wiz-Off!")
+	. += "\t[span_info("Each player draws 5 cards.")]"


Why was this even touched?

cacogen · 2022-04-02T10:54:05Z

combat text changed from limb name to limb body zone.

I don't think you did...

* i wanna go to bed so im pushing this * It compiles but doesn't work yet * It works! * I WANT TO DIE * Appease linters * some CI fixes * Address reviews + oversight * Limb grower fix * more icon fixes * forgot to hit save * I'm a dumbass * Removes bodypart parent from unit test * Fixes monkeys and CI * Grammar pass * I hate zombie code so much * General code cleanup * THE SHITCODERS ARE COMING FOR MY VARS * THE UNIT TESTS ARE COMING FOR MY SHITCODE * Reviews + skirts * Removes an unused DMI * Why didn't I do this in the first place? * HAIR REFACTOR * Haha whoops * How did I miss this * Admin spawned creatures now have their features * Optimize me harder * minor fix i need to push to merge master * Fixes hair (maybe) and a runtime * Maybe fixes mirrors * Attempts to fix women * Fixes hair on dismembered heads and a grammar change * Caps lock did me dirty * address reviews * icon failures fix + missed reviews * Fixes: Facehuggers and Regenerate_limb * Fixes ethereal color pref appearance * How the fuck did this not break everything else horribly? * JESUS FUCKING CHRIST IM A MORON * Fixes compile * I'm not high I swear * Im a dipshiiiit * grumble grumble * Fixes a visual bug with digitigrade legs. Adds \improper to roundstart species names. Added two new clothing-related helper procs. Renamed a couple procs to be more accurate. Adds SHOULD_CALL_PARENT(TRUE) to examine_more. Addresses reviews. * Forgot this little readability thing. * Updates CODEOWNERS * Me when I forget how github works * mapload me harder * Last second fixes

ShibaInuLord · 2022-04-08T02:45:12Z

combat text changed from limb name to limb body zone.

I don't think you did...

he lied to me wow

cacogen · 2022-04-08T22:38:35Z

To be fair, there are a huge amount of messages that use a limb's name in the code. I'm guessing changing them all to refer to the body zone is probably not the best way to fix it.

I think you'd have to revert the limb names to be generic and have the species prefixed only in the places that need it.

#65523 made some changes to bodypart names that messed with the grammar of a few messages around the codebase by inserting the species of a bodypart where it's really not needed. For example: For most general combat/health cases, we don't need to worry about the species of a bodypart. So, this changes combat and wound messages back to simply displaying the relevant bodypart zone being attacked/affected. See below: dreamseeker_2022-04-10_02-05-55.png Let me know if I missed any! Why It's Good For The Game Better grammar Changelog cl Ryll/Shaps spellcheck: Wound and combat messages will no longer mention the species of an attacked bodypart when not appropriate /cl

* i wanna go to bed so im pushing this * It compiles but doesn't work yet * It works! * I WANT TO DIE * Appease linters * some CI fixes * Address reviews + oversight * Limb grower fix * more icon fixes * forgot to hit save * I'm a dumbass * Removes bodypart parent from unit test * Fixes monkeys and CI * Grammar pass * I hate zombie code so much * General code cleanup * THE SHITCODERS ARE COMING FOR MY VARS * THE UNIT TESTS ARE COMING FOR MY SHITCODE * Reviews + skirts * Removes an unused DMI * Why didn't I do this in the first place? * HAIR REFACTOR * Haha whoops * How did I miss this * Admin spawned creatures now have their features * Optimize me harder * minor fix i need to push to merge master * Fixes hair (maybe) and a runtime * Maybe fixes mirrors * Attempts to fix women * Fixes hair on dismembered heads and a grammar change * Caps lock did me dirty * address reviews * icon failures fix + missed reviews * Fixes: Facehuggers and Regenerate_limb * Fixes ethereal color pref appearance * How the fuck did this not break everything else horribly? * JESUS FUCKING CHRIST IM A MORON * Fixes compile * I'm not high I swear * Im a dipshiiiit * grumble grumble * Fixes a visual bug with digitigrade legs. Adds \improper to roundstart species names. Added two new clothing-related helper procs. Renamed a couple procs to be more accurate. Adds SHOULD_CALL_PARENT(TRUE) to examine_more. Addresses reviews. * Forgot this little readability thing. * Updates CODEOWNERS * Me when I forget how github works * mapload me harder * Last second fixes

* Removes some unnecessary species mentions from kapuparts (tgstation#66112) tgstation#65523 made some changes to bodypart names that messed with the grammar of a few messages around the codebase by inserting the species of a bodypart where it's really not needed. For example: For most general combat/health cases, we don't need to worry about the species of a bodypart. So, this changes combat and wound messages back to simply displaying the relevant bodypart zone being attacked/affected. See below: dreamseeker_2022-04-10_02-05-55.png Let me know if I missed any! Why It's Good For The Game Better grammar Changelog cl Ryll/Shaps spellcheck: Wound and combat messages will no longer mention the species of an attacked bodypart when not appropriate /cl * Continues removing unnecessary species names of bodyparts in visible messages (tgstation#67254) * removes some more unnecessary species mentions from bodypart messages Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>

i wanna go to bed so im pushing this

3331e9f

Kapu1178 requested review from ExcessiveUseOfCobblestone, Ryll-Ryll, ninjanomnom and Mothblocks as code owners March 17, 2022 02:53

Kapu1178 marked this pull request as draft March 17, 2022 02:53

tgstation-server added Code Improvement Code is now easier to copy paste. Fix Rewrites a bug so it appears in different circumstances Feature Exposes new bugs in interesting ways Refactor Makes the code harder to read labels Mar 17, 2022

github-actions bot requested a review from Fikou March 17, 2022 02:54

JohnFulpWillard reviewed Mar 17, 2022

View reviewed changes

code/modules/surgery/bodyparts/helpers.dm Show resolved Hide resolved

MrMelbert reviewed Mar 17, 2022

View reviewed changes

code/modules/mob/living/carbon/human/species.dm Outdated Show resolved Hide resolved

MrMelbert reviewed Mar 17, 2022

View reviewed changes

ChungusGamer666 reviewed Mar 17, 2022

View reviewed changes

code/modules/mob/living/carbon/human/human_update_icons.dm Outdated Show resolved Hide resolved

Time-Green reviewed Mar 17, 2022

View reviewed changes

code/modules/surgery/bodyparts/species_parts/vox_bodyparts.dm Outdated Show resolved Hide resolved

optimumtact added the Do Not Merge You must have really upset someone label Mar 17, 2022

dragomagol reviewed Mar 17, 2022

View reviewed changes

code/__DEFINES/mobs.dm Outdated Show resolved Hide resolved

Fikou reviewed Mar 17, 2022

View reviewed changes

code/__DEFINES/mobs.dm Show resolved Hide resolved

Fikou reviewed Mar 17, 2022

View reviewed changes

code/__DEFINES/mobs.dm Outdated Show resolved Hide resolved

OctusGit mentioned this pull request Mar 17, 2022

Kapu Limbs Port (WIP) pariahstation/Pariah-Station#9

Closed

It compiles but doesn't work yet

9283758

Kapu1178 added 2 commits March 31, 2022 20:20

Me when I forget how github works

838dc0c

mapload me harder

a415dd3

MrMelbert reviewed Apr 1, 2022

View reviewed changes

code/modules/zombie/organs.dm Outdated Show resolved Hide resolved

Last second fixes

05ed0e3

LemonInTheDark reviewed Apr 1, 2022

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

Kapu1178 requested a review from MrMelbert April 1, 2022 00:35

Ryll-Ryll merged commit 1d0eadc into tgstation:master Apr 2, 2022

tgstation-server added a commit that referenced this pull request Apr 2, 2022

Automatic changelog generation for PR #65523 [ci skip]

04f43d6

PariahBot mentioned this pull request Apr 2, 2022

[MIRROR] Kapulimbs pariahstation/Pariah-Station#216

Merged

TaleStationBot mentioned this pull request Apr 2, 2022

[MIRROR] [MDB IGNORE] Kapulimbs TaleStation/TaleStation#85

Merged

SkyratBot mentioned this pull request Apr 2, 2022

[MIRROR] Kapulimbs [MDB IGNORE] Skyrat-SS13/Skyrat-tg#12497

Merged

thgvr mentioned this pull request Apr 2, 2022

Digitigrade & Female jumpskirt overlay broken on assistant jumpsuit #65879

Closed

timothymtorres reviewed Apr 2, 2022

View reviewed changes

TheBoondock pushed a commit to TheBoondock/tgstation that referenced this pull request Apr 6, 2022

Automatic changelog generation for PR tgstation#65523 [ci skip]

cfc6d24

Ryll-Ryll mentioned this pull request Apr 10, 2022

Removes some unnecessary species mentions from kapuparts #66112

Merged

Kapu1178 mentioned this pull request May 31, 2022

Spritesheets port and a few alternate sprites for snouts yogstation13/Yogstation#14180

Closed

5 tasks

DoctorSquishy mentioned this pull request Jun 12, 2022

Caltrop Updates + Fixes Gravity Runtime [TG PORT] Monkestation/MonkeStation#468

Merged

PowerfulBacon mentioned this pull request Jul 6, 2022

[Bounty] Get our bodyparts/limbs/organs up to date with TG limbs. BeeStation/BeeStation-Hornet#7213

Open

Tsar-Salat mentioned this pull request Mar 21, 2024

Wounds Atomization: repairing clothes BeeStation/BeeStation-Hornet#10782

Merged

Tsar-Salat mentioned this pull request Aug 2, 2024

Fixes VV bodypart editor after 3 years BeeStation/BeeStation-Hornet#11282

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kapulimbs #65523

Kapulimbs #65523

Kapu1178 commented Mar 17, 2022 •

edited

Loading

optimumtact commented Mar 17, 2022

Archanial commented Mar 17, 2022

SuperNovaa41 commented Mar 17, 2022 •

edited

Loading

ExcessiveUseOfCobblestone commented Mar 17, 2022

AlinaStarkova commented Mar 17, 2022

Kapu1178 commented Mar 17, 2022

ShibaInuLord commented Mar 17, 2022 •

edited

Loading

JohnFulpWillard commented Mar 17, 2022

tralezab commented Apr 2, 2022

Kapu1178 commented Apr 2, 2022

Sinestia commented Apr 2, 2022

timothymtorres Apr 2, 2022

cacogen commented Apr 2, 2022 •

edited

Loading

ShibaInuLord commented Apr 8, 2022

cacogen commented Apr 8, 2022

Kapulimbs #65523

Kapulimbs #65523

Conversation

Kapu1178 commented Mar 17, 2022 • edited Loading

About The Pull Request

How is this achieved?

Why It's Good For The Game

Changelog

optimumtact commented Mar 17, 2022

Archanial commented Mar 17, 2022

SuperNovaa41 commented Mar 17, 2022 • edited Loading

ExcessiveUseOfCobblestone commented Mar 17, 2022

AlinaStarkova commented Mar 17, 2022

Kapu1178 commented Mar 17, 2022

ShibaInuLord commented Mar 17, 2022 • edited Loading

JohnFulpWillard commented Mar 17, 2022

tralezab commented Apr 2, 2022

Kapu1178 commented Apr 2, 2022

Sinestia commented Apr 2, 2022

timothymtorres Apr 2, 2022

Choose a reason for hiding this comment

cacogen commented Apr 2, 2022 • edited Loading

ShibaInuLord commented Apr 8, 2022

cacogen commented Apr 8, 2022

Kapu1178 commented Mar 17, 2022 •

edited

Loading

SuperNovaa41 commented Mar 17, 2022 •

edited

Loading

ShibaInuLord commented Mar 17, 2022 •

edited

Loading

cacogen commented Apr 2, 2022 •

edited

Loading