Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

[MIRROR] Kapulimbs #216

Merged
merged 2 commits into from
Apr 2, 2022
Merged

[MIRROR] Kapulimbs #216

merged 2 commits into from
Apr 2, 2022

Conversation

PariahBot
Copy link
Collaborator

Original PR: tgstation/tgstation#65523

About The Pull Request

Ports Kapulimbs 1.0 & 1.1 from Shiptest, while trimming some unrelated code.

Kapulimbs is a bodypart & update icons rewrite I created with a few specific intentions:

  1. Simplify the code
  2. Allow players to create frankensteins of different species parts
  3. Enable non-humanoid species to be created

How is this achieved?

Bodyparts are now pathed to their specific species, and they can have their own unique life loops, appearances, and anything else a bodypart child should have. A "bodytypes" bitfield is utilized to differentiate important attributes, such as BODYTYPE_ORGANIC and BODYTYPE_HUMANOID.

Why It's Good For The Game

Better code AND better fun.
image

Changelog

🆑
add: Limbgrower limbs are now a sickly green
refactor: Digitigrade legs should now behave consistently.
refactor: Limbs will no longer update appearance as owner is transferred, allowing for multi-species frankensteins
fix: CHANGELING TRANSFORM FUNCTIONS PROPERLY
del: Synths and synth-related mechanics (Synth fugative)
/:cl:

Kapu1178 and others added 2 commits April 2, 2022 01:08
* i wanna go to bed so im pushing this

* It compiles but doesn't work yet

* It works!

* I WANT TO DIE

* Appease linters

* some CI fixes

* Address reviews + oversight

* Limb grower fix

* more icon fixes

* forgot to hit save

* I'm a dumbass

* Removes bodypart parent from unit test

* Fixes monkeys and CI

* Grammar pass

* I hate zombie code so much

* General code cleanup

* THE SHITCODERS ARE COMING FOR MY VARS

* THE UNIT TESTS ARE COMING FOR MY SHITCODE

* Reviews + skirts

* Removes an unused DMI

* Why didn't I do this in the first place?

* HAIR REFACTOR

* Haha whoops

* How did I miss this

* Admin spawned creatures now have their features

* Optimize me harder

* minor fix i need to push to merge master

* Fixes hair (maybe) and a runtime

* Maybe fixes mirrors

* Attempts to fix women

* Fixes hair on dismembered heads and a grammar change

* Caps lock did me dirty

* address reviews

* icon failures fix + missed reviews

* Fixes: Facehuggers and Regenerate_limb

* Fixes ethereal color pref appearance

* How the fuck did this not break everything else horribly?

* JESUS FUCKING CHRIST IM A MORON

* Fixes compile

* I'm not high I swear

* Im a dipshiiiit

* grumble grumble

* Fixes a visual bug with digitigrade legs. Adds \improper to roundstart species names. Added two new clothing-related helper procs. Renamed a couple procs to be more accurate. Adds SHOULD_CALL_PARENT(TRUE) to examine_more. Addresses reviews.

* Forgot this little readability thing.

* Updates CODEOWNERS

* Me when I forget how github works

* mapload me harder

* Last second fixes
@OctusGit OctusGit added Upstream mirror Mirror bot/PRs we got from upstream. Big PR It's not the size that matters... but someone will have to review this. labels Apr 2, 2022
@OctusGit OctusGit merged commit a9d5bbb into master Apr 2, 2022
@OctusGit OctusGit deleted the upstream-merge-65523 branch April 2, 2022 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Big PR It's not the size that matters... but someone will have to review this. Upstream mirror Mirror bot/PRs we got from upstream.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants