Holocene: Use ExtraData instead of Nonce for eip1559Params #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImTei
reviewed
Oct 16, 2024
turbo/engineapi/engine_server.go
Outdated
| if len(req.EIP1559Params) != 8 { | ||
| return nil, &rpc.InvalidParamsError{Message: fmt.Sprintf("invalid EIP1559Params length: %v", len(req.EIP1559Params))} | ||
| } | ||
| copy(header.Nonce[:], req.EIP1559Params) |
There was a problem hiding this comment.
shouldn't we use extraData to contain EIP1559Params?
There was a problem hiding this comment.
The spec was updated 5 hours ago, I will update the code tomorrow. :)
There was a problem hiding this comment.
I've updated the code to match the spec and the geth change!
mininny
force-pushed
the
feature/mininny/holocene-execution-payload
branch
2 times, most recently
from
fa4005a to
3b20a35
Compare
mininny
force-pushed
the
feature/mininny/holocene-execution-payload
branch
from
3b20a35 to
5699df6
Compare
mininny
changed the title
ImTei
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Holocene EIP-1559 parameters need to also be in the execution payload so the payload otherwise it won't be able to populate the nonce field appropriately when materializing the block.
Additional context
Corresponding spec update: ethereum-optimism/specs#428
Mirror of op-geth change: ethereum-optimism/op-geth#402